-
Notifications
You must be signed in to change notification settings - Fork 799
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix querier limiter bug under multiselect #5627
Conversation
0b074b5
to
d3a82ec
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's add unit tests to make sure this uses the same limiter for multiple selects
d3a82ec
to
e5924ca
Compare
c0159e5
to
e53d660
Compare
Nice! After we could also try to add a integ test on this. |
e3e2482
to
fc2b3df
Compare
Yes, will submit a separate PR for that |
Signed-off-by: Anand Rajagopal <[email protected]>
fc2b3df
to
84751de
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
What this PR does:
Which issue(s) this PR fixes:
This PR is a fix for #5620
Checklist
CHANGELOG.md
updated - the order of entries should be[CHANGE]
,[FEATURE]
,[ENHANCEMENT]
,[BUGFIX]