Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix querier limiter bug under multiselect #5627

Merged
merged 1 commit into from
Nov 1, 2023

Conversation

rajagopalanand
Copy link
Contributor

@rajagopalanand rajagopalanand commented Oct 31, 2023

What this PR does:

Which issue(s) this PR fixes:

This PR is a fix for #5620

Checklist

  • Tests updated
  • Documentation added
  • CHANGELOG.md updated - the order of entries should be [CHANGE], [FEATURE], [ENHANCEMENT], [BUGFIX]

Copy link
Contributor

@yeya24 yeya24 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's add unit tests to make sure this uses the same limiter for multiple selects

@alanprot
Copy link
Member

alanprot commented Nov 1, 2023

Nice!

After we could also try to add a integ test on this.

pkg/querier/querier_test.go Outdated Show resolved Hide resolved
pkg/querier/querier_test.go Outdated Show resolved Hide resolved
@rajagopalanand rajagopalanand force-pushed the issue-5620 branch 2 times, most recently from e3e2482 to fc2b3df Compare November 1, 2023 18:59
@rajagopalanand
Copy link
Contributor Author

rajagopalanand commented Nov 1, 2023

Nice!

After we could also try to add a integ test on this.

Yes, will submit a separate PR for that

@rajagopalanand rajagopalanand changed the title Fix for https://github.com/cortexproject/cortex/issues/5620 Fix querier limiter bug under multiselect Nov 1, 2023
Signed-off-by: Anand Rajagopal <[email protected]>
Copy link
Contributor

@yeya24 yeya24 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yeya24 yeya24 merged commit 752c354 into cortexproject:master Nov 1, 2023
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants