Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Query limits are not applied properly since the prometheus upgrade #5620

Closed
rajagopalanand opened this issue Oct 25, 2023 · 1 comment
Closed
Labels

Comments

@rajagopalanand
Copy link
Contributor

PR #5593 introduced changes in how context is passed. Context is now passed to the select method. Previously, context was stored in querier and the query limiter that was stored in the context could be shared across multiple select method calls. Now, since the query limiter is newly constructed in setupFromCtx on every select function call, the limits are not being applied correctly and can potentially result in out of memory errors. The limit is now applied per select call instead of per query which would allow queries that result in multiple select calls to use significantly higher memory

rajagopalanand added a commit to rajagopalanand/rajagopalanand-cortex that referenced this issue Oct 31, 2023
Signed-off-by: Anand Rajagopal <[email protected]>
rajagopalanand added a commit to rajagopalanand/rajagopalanand-cortex that referenced this issue Oct 31, 2023
Signed-off-by: Anand Rajagopal <[email protected]>
rajagopalanand added a commit to rajagopalanand/rajagopalanand-cortex that referenced this issue Nov 1, 2023
Signed-off-by: Anand Rajagopal <[email protected]>
rajagopalanand added a commit to rajagopalanand/rajagopalanand-cortex that referenced this issue Nov 1, 2023
Signed-off-by: Anand Rajagopal <[email protected]>
rajagopalanand added a commit to rajagopalanand/rajagopalanand-cortex that referenced this issue Nov 1, 2023
Signed-off-by: Anand Rajagopal <[email protected]>
rajagopalanand added a commit to rajagopalanand/rajagopalanand-cortex that referenced this issue Nov 1, 2023
Signed-off-by: Anand Rajagopal <[email protected]>
rajagopalanand added a commit to rajagopalanand/rajagopalanand-cortex that referenced this issue Nov 1, 2023
Signed-off-by: Anand Rajagopal <[email protected]>
rajagopalanand added a commit to rajagopalanand/rajagopalanand-cortex that referenced this issue Nov 1, 2023
Signed-off-by: Anand Rajagopal <[email protected]>
rajagopalanand added a commit to rajagopalanand/rajagopalanand-cortex that referenced this issue Nov 1, 2023
Signed-off-by: Anand Rajagopal <[email protected]>
yeya24 pushed a commit that referenced this issue Nov 1, 2023
Signed-off-by: Anand Rajagopal <[email protected]>
@yeya24
Copy link
Contributor

yeya24 commented Nov 2, 2023

Resolved by #5627

@yeya24 yeya24 closed this as completed Nov 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants