-
Notifications
You must be signed in to change notification settings - Fork 799
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Query limits are not applied properly since the prometheus upgrade #5620
Labels
Comments
rajagopalanand
added a commit
to rajagopalanand/rajagopalanand-cortex
that referenced
this issue
Oct 31, 2023
Signed-off-by: Anand Rajagopal <[email protected]>
3 tasks
rajagopalanand
added a commit
to rajagopalanand/rajagopalanand-cortex
that referenced
this issue
Oct 31, 2023
Signed-off-by: Anand Rajagopal <[email protected]>
rajagopalanand
added a commit
to rajagopalanand/rajagopalanand-cortex
that referenced
this issue
Nov 1, 2023
Signed-off-by: Anand Rajagopal <[email protected]>
rajagopalanand
added a commit
to rajagopalanand/rajagopalanand-cortex
that referenced
this issue
Nov 1, 2023
Signed-off-by: Anand Rajagopal <[email protected]>
rajagopalanand
added a commit
to rajagopalanand/rajagopalanand-cortex
that referenced
this issue
Nov 1, 2023
Signed-off-by: Anand Rajagopal <[email protected]>
rajagopalanand
added a commit
to rajagopalanand/rajagopalanand-cortex
that referenced
this issue
Nov 1, 2023
Signed-off-by: Anand Rajagopal <[email protected]>
rajagopalanand
added a commit
to rajagopalanand/rajagopalanand-cortex
that referenced
this issue
Nov 1, 2023
Signed-off-by: Anand Rajagopal <[email protected]>
rajagopalanand
added a commit
to rajagopalanand/rajagopalanand-cortex
that referenced
this issue
Nov 1, 2023
Signed-off-by: Anand Rajagopal <[email protected]>
rajagopalanand
added a commit
to rajagopalanand/rajagopalanand-cortex
that referenced
this issue
Nov 1, 2023
Signed-off-by: Anand Rajagopal <[email protected]>
yeya24
pushed a commit
that referenced
this issue
Nov 1, 2023
Resolved by #5627 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
PR #5593 introduced changes in how context is passed. Context is now passed to the
select
method. Previously, context was stored in querier and the query limiter that was stored in the context could be shared across multipleselect
method calls. Now, since the query limiter is newly constructed insetupFromCtx
on everyselect
function call, the limits are not being applied correctly and can potentially result in out of memory errors. The limit is now applied perselect
call instead of per query which would allow queries that result in multipleselect
calls to use significantly higher memoryThe text was updated successfully, but these errors were encountered: