Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(cachi2): single remote source name #2133

Merged

Conversation

MartinBasti
Copy link
Contributor

When single remote source is used, returned name should be None and not an empty string. This si compatible with Cachito behavior.

Maintainers will complete the following section

  • Commit messages are descriptive enough
  • Code coverage from testing does not decrease and new code is covered
  • Python type annotations added to new code
  • JSON/YAML configuration changes are updated in the relevant schema
  • Changes to metadata also update the documentation for the metadata
  • Pull request has a link to an osbs-docs PR for user documentation updates
  • New feature can be disabled from a configuration file

When single remote source is used, returned name should be None and not
an empty string. This si compatible with Cachito behavior.

Signed-off-by: Martin Basti <[email protected]>
@MartinBasti MartinBasti merged commit 9aa49c4 into containerbuildsystem:feature_cachi2 Nov 28, 2024
14 of 15 checks passed
@MartinBasti MartinBasti deleted the fix-name-metadata branch November 28, 2024 13:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants