fix(cachi2): single remote source name

When single remote source is used, returned name should be None and not an empty string. This si compatible with Cachito behavior. Signed-off-by: Martin Basti <[email protected]>
containerbuildsystem · Nov 28, 2024 · 9aa49c4 · 9aa49c4
1 parent 2b7138a
commit 9aa49c4
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/atomic_reactor/plugins/cachi2_init.py b/atomic_reactor/plugins/cachi2_init.py
@@ -78,7 +78,7 @@ def process_remote_sources(self) -> List[Dict[str, Any]]:
         remote_sources = self.multiple_remote_sources_params
         if self.single_remote_source_params:
             remote_sources = [{
-                "name": "",  # name single remote source with generic name
+                "name": None,
                 "remote_source": self.single_remote_source_params}]
 
         processed_remote_sources = []

diff --git a/tests/plugins/test_cachi2_init.py b/tests/plugins/test_cachi2_init.py
@@ -133,7 +133,7 @@ def test_single_remote_source_initialization(workflow, mocked_cachi2_init):
         '/remote-source')
 
     assert result == [{
-        "name": "",
+        "name": None,
         "source_path": str(
             workflow.build_dir.path / CACHI2_BUILD_DIR / CACHI2_SINGLE_REMOTE_SOURCE_NAME),
         "remote_source": {