Update reference to connectrpc/conformance #894
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
smaye81
approved these changes
Oct 31, 2023
rebello95
added a commit
to connectrpc/connect-swift
that referenced
this pull request
Dec 10, 2023
Fixes 2 issues with CI on main: 1. `brew` is not properly installing `docker` because some Python dependencies need to be forcibly unlinked/removed before installing it (more info [here](pypa/pipenv#3831)): ``` ==> Pouring maven--3.9.6.ventura.bottle.tar.gz 🍺 /usr/local/Cellar/maven/3.9.6: 92 files, 10.4MB ==> Upgrading [email protected] 3.12.0 -> 3.12.0_1 ==> Pouring [email protected]_1.ventura.bottle.tar.gz Error: The `brew link` step did not complete successfully The formula built, but is not symlinked into /usr/local Could not symlink bin/2to3-3.12 Target /usr/local/bin/2to3-3.12 already exists. You may want to remove it: rm '/usr/local/bin/2to3-3.12' To force the link and overwrite all conflicting files: brew link --overwrite [email protected] To list all files that would be deleted: brew link --overwrite --dry-run [email protected] ``` 2. The conformance test repo is pinned to a version too far in the past, so the sha is not included in the default clone depth and thus cannot be found. This PR bumps the ref (see connectrpc/connect-es#894)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We generate proto files for the conformance tests from a git reference:
Because of recent activity in connectrpc/conformance, we're falling outside of the range of the default clone settings. We could add
,depth=100to the URL to fix the problem, but it makes sense to update to the most recent version.