Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix CI jobs #228

Merged
merged 12 commits into from
Dec 10, 2023
Merged

Fix CI jobs #228

merged 12 commits into from
Dec 10, 2023

Conversation

rebello95
Copy link
Collaborator

@rebello95 rebello95 commented Dec 9, 2023 •
edited
Loading

Fixes 2 issues with CI on main:

  1. brew is not properly installing docker because some Python dependencies need to be forcibly unlinked/removed before installing it (more info here):
==> Pouring maven--3.9.6.ventura.bottle.tar.gz
🍺  /usr/local/Cellar/maven/3.9.6: 92 files, 10.4MB
==> Upgrading [email protected]
  3.12.0 -> 3.12.0_1 

==> Pouring [email protected]_1.ventura.bottle.tar.gz
Error: The `brew link` step did not complete successfully
The formula built, but is not symlinked into /usr/local
Could not symlink bin/2to3-3.12
Target /usr/local/bin/2to3-3.12
already exists. You may want to remove it:
  rm '/usr/local/bin/2to3-3.12'

To force the link and overwrite all conflicting files:
  brew link --overwrite [email protected]

To list all files that would be deleted:
  brew link --overwrite --dry-run [email protected]
  1. The conformance test repo is pinned to a version too far in the past, so the sha is not included in the default clone depth and thus cannot be found. This PR bumps the ref (see Update reference to connectrpc/conformance connect-es#894)

@rebello95 rebello95 changed the title Test CI Fix CI jobs Dec 9, 2023
@rebello95 rebello95 requested review from timostamm and eseay December 9, 2023 22:20
@rebello95 rebello95 mentioned this pull request Dec 9, 2023
Merged
1 task
@rebello95 rebello95 requested a review from nicksnyder December 9, 2023 22:23
@rebello95
Copy link
Collaborator Author

Ok, finally passing 😅

@rebello95 rebello95 merged commit 2ca8739 into main Dec 10, 2023
11 checks passed
@rebello95 rebello95 deleted the test-ci branch December 10, 2023 05:46
@rebello95 rebello95 mentioned this pull request Dec 10, 2023
Merged
rebello95 added a commit that referenced this pull request Dec 11, 2023
@rebello95
Fix new CI failure (#230)
58e8802 
Although the fix in #228 passed CI on the PR, it failed on `main`. As
far as I can tell, it seems to be inconsistent depending on which GitHub
runner gets assigned to the job. After further experimentation and
digging, it looks like `colima` [had some breaking changes from 0.5.x ->
0.6.x](https://github.com/abiosoft/colima/releases/tag/v0.6.6) which
require `colima delete` to be run prior to starting. The changes in this
PR address the issue, and I've re-run CI multiple times on this PR to
try on multiple runners.

Thankfully, we'll be able to axe this setup once we switch to the new
conformance runner.

Error:

```
==> Pouring [email protected]_1.ventura.bottle.tar.gz
Error: The `brew link` step did not complete successfully
The formula built, but is not symlinked into /usr/local
Could not symlink bin/python3.12
Target /usr/local/bin/python3.12
already exists. You may want to remove it:
  rm '/usr/local/bin/python3.12'
```
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@akshayjshah akshayjshah akshayjshah approved these changes

@smaye81 smaye81 smaye81 approved these changes

@timostamm timostamm Awaiting requested review from timostamm

@eseay eseay Awaiting requested review from eseay

@nicksnyder nicksnyder Awaiting requested review from nicksnyder

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rebello95 @smaye81 @akshayjshah