-
-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
pin to zarr<3 #23
pin to zarr<3 #23
Conversation
Hi! This is the friendly automated conda-forge-linting service. I wanted to let you know that I linted all conda-recipes in your PR ( Here's what I've got... For recipe/meta.yaml:
For recipe/meta.yaml:
This message was generated by GitHub Actions workflow run https://github.com/conda-forge/conda-forge-webservices/actions/runs/12717912036. Examine the logs at this URL for more detail. |
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( I do have some suggestions for making it better though... For recipe/meta.yaml:
This message was generated by GitHub Actions workflow run https://github.com/conda-forge/conda-forge-webservices/actions/runs/12717971117. Examine the logs at this URL for more detail. |
@@ -32,7 +32,7 @@ requirements: | |||
- requests | |||
- scikit-image | |||
- toolz | |||
- zarr >=2.8.1 | |||
- zarr <3 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We may want to add a repodata patch for older version to ensure they can't be installed with Zarr v3
A simple example that could be tailored to our needs is PR: conda-forge/conda-forge-repodata-patches-feedstock#937
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah, ok. That's what @psobolewskiPhD meant in conda-forge/napari-ome-zarr-feedstock#10 (comment)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See conda-forge/conda-forge-repodata-patches-feedstock#940
I'm unsure whether or not to include a napari-ome-zarr.yaml or just ping napari-ome-zarr to 0.10.3 (seems too restrictive)
Checklist
0
(if the version changed)conda-smithy
(Use the phrase@conda-forge-admin, please rerender
in a comment in this PR for automated rerendering)