Rebuild for CFEP-25 `noarch: python` syntax #10

regro-cf-autotick-bot · 2024-12-29T03:39:16Z

This PR updates the recipe to use the noarch: python syntax as described in CFEP-25. Please see our documentation for more details.

If this PR was opened in error or needs to be updated please add the bot-rerun label to this PR. The bot will close this PR and schedule another one. If you do not have permissions to add this label, you can use the phrase @conda-forge-admin, please rerun bot in a PR comment to have the conda-forge-admin add it for you.

_{This PR was created by the regro-cf-autotick-bot. The regro-cf-autotick-bot is a service to automatically track the dependency graph, migrate packages, and propose package version updates for conda-forge. Feel free to drop us a line if there are any issues! This PR was generated by https://github.com/regro/cf-scripts/actions/runs/12532136803 - please use this URL for debugging.}

…onda-forge-pinning 2024.12.28.18.49.41

conda-forge-admin · 2024-12-29T03:40:35Z

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe/meta.yaml) and found it was in an excellent condition.

I do have some suggestions for making it better though...

For recipe/meta.yaml:

ℹ️ No valid build backend found for Python recipe for package napari-ome-zarr using pip. Python recipes using pip need to explicitly specify a build backend in the host section. If your recipe has built with only pip in the host section in the past, you likely should add setuptools to the host section of your recipe.

_{This message was generated by GitHub Actions workflow run https://github.com/conda-forge/conda-forge-webservices/actions/runs/12532185458. Examine the logs at this URL for more detail.}

joshmoore · 2025-01-08T08:52:39Z

napari 0.5.5 has requirement numpy<2,>=1.22.2; python_version < "3.10", but you have numpy 2.0.2.
WARNING: Tests failed for napari-ome-zarr-0.6.1-pyha07c04f_1.conda - moving package to /home/conda/feedstock_root/build_artifacts/broken
Traceback (most recent call last):
  File "/opt/conda/lib/python3.12/site-packages/conda_build/build.py", line 3481, in test
    utils.check_call_env(
  File "/opt/conda/lib/python3.12/site-packages/conda_build/utils.py", line 406, in check_call_env
    return _func_defaulting_env_to_os_environ("call", *popenargs, **kwargs)
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/opt/conda/lib/python3.12/site-packages/conda_build/utils.py", line 382, in _func_defaulting_env_to_os_environ
    raise subprocess.CalledProcessError(proc.returncode, _args)
subprocess.CalledProcessError: Command '['/bin/bash', '-o', 'errexit', '/home/conda/feedstock_root/build_artifacts/napari-ome-zarr_1735443690745/test_tmp/conda_test_runner.sh']' returned non-zero exit status 1.

During handling of the above exception, another exception occurred:

Traceback (most recent call last):
  File "/opt/conda/bin/conda-build", line 11, in <module>
    sys.exit(execute())
             ^^^^^^^^^
  File "/opt/conda/lib/python3.12/site-packages/conda_build/cli/main_build.py", line 648, in execute
    api.build(
  File "/opt/conda/lib/python3.12/site-packages/conda_build/api.py", line 211, in build
    return build_tree(
           ^^^^^^^^^^^
  File "/opt/conda/lib/python3.12/site-packages/conda_build/build.py", line 3668, in build_tree
    test(pkg, config=metadata.config.copy(), stats=stats)
  File "/opt/conda/lib/python3.12/site-packages/conda_build/build.py", line 3495, in test
    tests_failed(
  File "/opt/conda/lib/python3.12/site-packages/conda_build/build.py", line 3542, in tests_failed
    raise CondaBuildUserError("TESTS FAILED: " + os.path.basename(pkg))
conda_build.exceptions.CondaBuildUserError: TESTS FAILED: napari-ome-zarr-0.6.1-pyha07c04f_1.conda

Randomly checking with @psobolewskiPhD in case he has a suggestion.

psobolewskiPhD · 2025-01-08T14:26:40Z

@joshmoore
The easy solution is to drop the pip check.
Otherwise, I've got a napari PR to resolve the discrepancy:
napari/napari#7500

jni · 2025-01-09T00:43:56Z

Given the issues with np2 in napari/napari#7500, I might suggest just setting python_min to 3.10 here. (And we might want to do the same in napari — SPEC0 suggests we even jump to 3.11!)

joshmoore · 2025-01-10T20:59:11Z

Considering conda-forge/ome-zarr-feedstock#22 I'll go ahead and set >3.10

conda-forge-admin · 2025-01-10T21:01:27Z

Hi! This is the friendly automated conda-forge-linting service.

I was trying to look for recipes to lint for you, but it appears we have a merge conflict. Please try to merge or rebase with the base branch to resolve this conflict.

Please ping the 'conda-forge/core' team (using the @ notation in a comment) if you believe this is a bug.

joshmoore · 2025-01-10T21:06:52Z

@conda-forge-admin, please rerender

…onda-forge-pinning 2025.01.10.08.48.29

conda-forge-admin · 2025-01-10T21:11:16Z

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe/meta.yaml) and found it was in an excellent condition.

I do have some suggestions for making it better though...

For recipe/meta.yaml:

ℹ️ No valid build backend found for Python recipe for package napari-ome-zarr using pip. Python recipes using pip need to explicitly specify a build backend in the host section. If your recipe has built with only pip in the host section in the past, you likely should add setuptools to the host section of your recipe.
ℹ️ noarch: python recipes should usually follow the syntax in our documentation for specifying the Python version.
- For the host section of the recipe, you should usually use python {{ python_min }} for the python entry.
- For the run section of the recipe, you should usually use python >={{ python_min }} for the python entry.
- For the test.requires section of the recipe, you should usually use python {{ python_min }} for the python entry.
- If the package requires a newer Python version than the currently supported minimum version on conda-forge, you can override the python_min variable by adding a Jinja2 set statement at the top of your recipe (or using an equivalent context variable for v1 recipes).

_{This message was generated by GitHub Actions workflow run https://github.com/conda-forge/conda-forge-webservices/actions/runs/12718187413. Examine the logs at this URL for more detail.}

joshmoore · 2025-01-10T21:24:25Z

...still unhappy :/

psobolewskiPhD · 2025-01-10T21:40:23Z

@joshmoore
With zarr 3.0.0 I can reproduce the CI fail locally:

In [1]: from zarr.storage import FSStore
---------------------------------------------------------------------------
ImportError                               Traceback (most recent call last)
Cell In[1], line 1
----> 1 from zarr.storage import FSStore

ImportError: cannot import name 'FSStore' from 'zarr.storage' (/Users/sobolp/micromamba/envs/napari-dev/lib/python3.12/site-packages/zarr/storage/__init__.py)

So that seems like a real fail in napari-ome-zarr.

joshmoore · 2025-01-10T21:46:59Z

Ah, thanks. But there is supposed to be a zarr<3 pin.... (cc: @will-moore)

psobolewskiPhD · 2025-01-10T21:50:50Z

ome-zarr-py has one in pyproject.toml
https://github.com/ome/ome-zarr-py/blob/1e3e3e22f63533ef8c89b2c874450f18f2ed8a37/pyproject.toml#L23
but not in the feedstock:
https://github.com/conda-forge/ome-zarr-feedstock/blob/main/recipe/meta.yaml
napari-ome-zarr does not in either place.

Probably solvable with a pinning PR to add the zarr<3 somewhere

joshmoore · 2025-01-10T21:54:40Z

napari-ome-zarr does not in either place.

Ok. Fair enough. Though in pip-land it should be transitive. (I feel a Friday evening rant about DRY but that's probably not useful... 😄)

Probably solvable with a pinning PR to add the zarr<3 somewhere

or when https://anaconda.org/search?q=ome-zarr shows 0.10.3 will it pan out?

psobolewskiPhD · 2025-01-10T21:57:28Z

I was just checking stuff. I agree, I think ome-zarr feedstock is the issue.

psobolewskiPhD · 2025-01-10T22:00:37Z

or when https://anaconda.org/search?q=ome-zarr shows 0.10.3 will it pan out?

I don't think so? that feedstock doesn't set zarr upper:
https://github.com/conda-forge/ome-zarr-feedstock/blob/f295096299e6a65b95ee632df9c612aa8ac47a3e/recipe/meta.yaml#L35

psobolewskiPhD · 2025-01-10T22:02:36Z

I think you need a patch PR like:
https://github.com/conda-forge/conda-forge-repodata-patches-feedstock/pull/477/files

joshmoore · 2025-01-10T22:23:43Z

I think you need a patch PR like:

???

in the meantime, I'm waiting on the builds from merging conda-forge/ome-zarr-feedstock#23 to pass so we can get 0.10.3 packages.

joshmoore · 2025-01-10T22:24:59Z

@conda-forge-admin, please restart ci

joshmoore · 2025-01-10T22:34:58Z

Oooh. Green. @psobolewskiPhD: shall we try merging to end the week with a bang?

psobolewskiPhD · 2025-01-11T01:47:13Z

Oooh. Green. @psobolewskiPhD: shall we try merging to end the week with a bang?

Ive got a (long running) serious case of merging anxiety--probably terminal honestly--so you're asking the wrong person!
🥶

joshmoore · 2025-01-11T11:48:41Z

Ok. I'm merging so that we have a currently building space. This may need one more commit depending on the outcome of conda-forge/conda-forge-repodata-patches-feedstock#940

regro-cf-autotick-bot added 2 commits December 29, 2024 03:38

update to CFEP-25 noarch: python syntax

929b2bc

MNT: Re-rendered with conda-build 24.11.2, conda-smithy 3.45.1, and c…

9459e7f

…onda-forge-pinning 2024.12.28.18.49.41

regro-cf-autotick-bot requested review from goanpeca, jaimergp, jburel, joshmoore, sbesson and will-moore as code owners December 29, 2024 03:39

psobolewskiPhD mentioned this pull request Jan 8, 2025

Update pyproject.toml remove upper bound on numpy on python 3.9 napari/napari#7500

Open

sbesson removed their request for review January 10, 2025 09:40

Hard-code python_min to >3.10

e926847

MNT: Re-rendered with conda-build 24.11.2, conda-smithy 3.45.1, and c…

810031c

…onda-forge-pinning 2025.01.10.08.48.29

conda-forge-webservices bot closed this Jan 10, 2025

conda-forge-webservices bot reopened this Jan 10, 2025

Add grayskull

d70fc16

joshmoore mentioned this pull request Jan 11, 2025

pin to zarr<3 conda-forge/ome-zarr-feedstock#23

Merged

5 tasks

joshmoore merged commit d3d5604 into conda-forge:main Jan 11, 2025
4 checks passed

regro-cf-autotick-bot deleted the noarch_python_min-migration-1_h3dee2c branch January 11, 2025 11:49

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Rebuild for CFEP-25 `noarch: python` syntax #10

Rebuild for CFEP-25 `noarch: python` syntax #10

regro-cf-autotick-bot commented Dec 29, 2024

conda-forge-admin commented Dec 29, 2024

joshmoore commented Jan 8, 2025

psobolewskiPhD commented Jan 8, 2025

jni commented Jan 9, 2025

joshmoore commented Jan 10, 2025

conda-forge-admin commented Jan 10, 2025

joshmoore commented Jan 10, 2025

conda-forge-admin commented Jan 10, 2025 •

edited

Loading

joshmoore commented Jan 10, 2025

psobolewskiPhD commented Jan 10, 2025

joshmoore commented Jan 10, 2025

psobolewskiPhD commented Jan 10, 2025 •

edited

Loading

joshmoore commented Jan 10, 2025 •

edited

Loading

psobolewskiPhD commented Jan 10, 2025

psobolewskiPhD commented Jan 10, 2025

psobolewskiPhD commented Jan 10, 2025

joshmoore commented Jan 10, 2025

joshmoore commented Jan 10, 2025

joshmoore commented Jan 10, 2025

psobolewskiPhD commented Jan 11, 2025

joshmoore commented Jan 11, 2025

Rebuild for CFEP-25 noarch: python syntax #10

Rebuild for CFEP-25 noarch: python syntax #10

Conversation

regro-cf-autotick-bot commented Dec 29, 2024

conda-forge-admin commented Dec 29, 2024

joshmoore commented Jan 8, 2025

psobolewskiPhD commented Jan 8, 2025

jni commented Jan 9, 2025

joshmoore commented Jan 10, 2025

conda-forge-admin commented Jan 10, 2025

joshmoore commented Jan 10, 2025

conda-forge-admin commented Jan 10, 2025 • edited Loading

joshmoore commented Jan 10, 2025

psobolewskiPhD commented Jan 10, 2025

joshmoore commented Jan 10, 2025

psobolewskiPhD commented Jan 10, 2025 • edited Loading

joshmoore commented Jan 10, 2025 • edited Loading

psobolewskiPhD commented Jan 10, 2025

psobolewskiPhD commented Jan 10, 2025

psobolewskiPhD commented Jan 10, 2025

joshmoore commented Jan 10, 2025

joshmoore commented Jan 10, 2025

joshmoore commented Jan 10, 2025

psobolewskiPhD commented Jan 11, 2025

joshmoore commented Jan 11, 2025

Rebuild for CFEP-25 `noarch: python` syntax #10

Rebuild for CFEP-25 `noarch: python` syntax #10

conda-forge-admin commented Jan 10, 2025 •

edited

Loading

psobolewskiPhD commented Jan 10, 2025 •

edited

Loading

joshmoore commented Jan 10, 2025 •

edited

Loading