This repository has been archived by the owner on Apr 4, 2024. It is now read-only.
Export files from UI #205
Merged
Export files from UI #205
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bryfox
changed the title
bryfox
commented
Dec 13, 2018
| @@ -5,8 +5,16 @@ const nodeAttributesProperty = 'attributes'; | |||
|
|
|||
| const getNodeAttributes = node => node[nodeAttributesProperty] || {}; | |||
|
|
|||
| const unionOfNetworks = networks => | |||
There was a problem hiding this comment.
I'm not sure what's really intended with the merged network. If interview nodes aren't disjoint (say because the same person was added from external data), then that person would be duplicated. On one hand, that might be desired: what we're importing isn't the entity, but the person with attributes from an interview (something like an ego's view of the entity?). On the other hand, based on existing NC implementation, we'd have duplicate UIDs.
bryfox
force-pushed
the
feature/graphml
branch
2 times, most recently
from
a9875f0 to
777355a
Compare
JSZip doesn't appear to provide an API for accepting input streams of data. TODO: replace JSZip usage elsewhere.
Avoid needing a required check
bryfox
force-pushed
the
feature/export-ui-integration
branch
from
d691265 to
d5be821
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #22. Depends on #198, #201, #203.
The following export options are supported:
Known issues:
creates temp files that should be manually cleaned upcancellation not yet implementedgraphML doesn't respect directed edge settingerror messages could be better