This repository has been archived by the owner on Apr 4, 2024. It is now read-only.
Implement filter & query backend #211
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bryfox
commented
Dec 13, 2018
| .then(networks => (exportNetworkUnion ? [unionOfNetworks(networks)] : networks)) | ||
| .then((networks) => { | ||
| .then(networks => filterNetworkEntities(networks, entityFilter)) |
There was a problem hiding this comment.
With #199, this order will probably need to change. I don't think it makes sense to insert an ego into the merged network, and filtering needs to happen before ego insertion. So the flow might be query -> filter -> insertEgo -> merge -> export.
rebeccamadsen
approved these changes
Dec 20, 2018
bryfox
force-pushed
the
feature/export-ui-integration
branch
from
d691265 to
d5be821
Compare
Ignore networkQuery in preflight tasks
Filter components from Architect work with IDs, not names, but our imported data has been transposed from ID->name. By transposing a copy of the registry, we don't need to modify the filtering components.
bryfox
force-pushed
the
feature/filter-query-backend
branch
from
0d22b8c to
74cdd02
Compare
bryfox
changed the title
jthrilly
pushed a commit
that referenced
this pull request
Jul 24, 2020
Implement filter & query backend
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on #205. Resolves #208 and #209.
This adds the main process scaffolding to support queries and filters. During the export flow, it runs a supplied user query to include only a subset of networks in export. It subsequently (after optionally merging all networks) filters all network nodes & edges before exporting.
It also wires up the temporary filter UI for network filtering; the UI may change as part of #200, but the interface should stay the same. (There is no querying UI yet.)
To test the filtering, you'll need to export fresh data from NC and ensure that your NC build includes https://github.com/codaco/Network-Canvas/pull/811.