Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add additionalNginxSettings for frontend configuration #530

Merged
merged 6 commits into from
Nov 4, 2024
Merged

add additionalNginxSettings for frontend configuration #530

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
f0de505
add additionalNginxSettings for frontend configuration
liyaka Oct 31, 2024
b458f2d
Update Helm documentation
CometActions Oct 31, 2024
c119456
update workflows to use the latest version of checkout action
liyaka Nov 4, 2024
f015b30
set default client_max_body_size to 500M
liyaka Nov 4, 2024
19454c2
Update Helm documentation
CometActions Nov 4, 2024
717e950
fix
liyaka Nov 4, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/documentation_cookbook_tests.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ jobs:
env:
NOTEBOOK_TO_TEST: ${{ matrix.notebooks }}
steps:
- uses: actions/checkout@v3
- uses: actions/checkout@v4
- uses: actions/setup-python@v4
with:
python-version: ${{ matrix.python-version }}
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/lib-langchain-tests.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ jobs:

steps:
- name: Check out code
uses: actions/checkout@v3
uses: actions/checkout@v4

- name: Setup Python ${{matrix.python_version}}
uses: actions/setup-python@v5
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/lib-llama-index-tests.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ jobs:

steps:
- name: Check out code
uses: actions/checkout@v3
uses: actions/checkout@v4

- name: Setup Python ${{matrix.python_version}}
uses: actions/setup-python@v5
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/lib-openai-tests.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ jobs:

steps:
- name: Check out code
uses: actions/checkout@v3
uses: actions/checkout@v4

- name: Setup Python ${{matrix.python_version}}
uses: actions/setup-python@v5
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/python_sdk_linter.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ jobs:
run:
working-directory: sdks/python
steps:
- uses: actions/checkout@v3
- uses: actions/checkout@v4
- name: install pre-commit
run: pip install pre-commit
- name: linting
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/python_sdk_unit_tests.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ jobs:

steps:
- name: Check out code
uses: actions/checkout@v3
uses: actions/checkout@v4

- name: Print environment variables
run: env
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/sanity.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ jobs:

steps:
- name: Checkout repo
uses: actions/checkout@v3
uses: actions/checkout@v4
with:
ref: ${{ github.ref }}

Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/test_installer.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ jobs:

steps:
- name: Checkout repo
uses: actions/checkout@v3
uses: actions/checkout@v4
with:
ref: ${{ github.ref }}

Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/update_helm_readme.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ jobs:
update-readme:
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v3
- uses: actions/checkout@v4
with:
ref: ${{ github.event.pull_request.head.ref }}

Expand Down
5 changes: 4 additions & 1 deletion deployment/helm_chart/opik/templates/configmap-frontend-nginx.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,6 @@ data:
gzip_http_version 1.1;
gzip_min_length 256;
gzip_types text/plain text/css application/json application/x-javascript text/xml application/xml application/xml+rss text/javascript application/vnd.ms-fontobject application/x-font-ttf font/opentype image/svg+xml image/x-icon application/javascript;
client_max_body_size 500M;
absolute_redirect off;
real_ip_header X-Forwarded-For;
real_ip_recursive on;
Expand All @@ -24,6 +23,10 @@ data:
limit_req_log_level info;
limit_req_status 429;
map_hash_bucket_size 256;
client_max_body_size 500M;
{{- with .Values.component.frontend.additionalNginxSettings }}
{{- . | nindent 4 }}
{{- end }}
{{- if .Values.component.frontend.awsResolver }}
resolver 169.254.169.253 valid=10s;
{{- end }}
Expand Down
4 changes: 1 addition & 3 deletions deployment/helm_chart/opik/values.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -81,8 +81,7 @@ component:

ingress:
enabled: false



frontend:
serviceAccount:
create: true
Expand Down Expand Up @@ -110,7 +109,6 @@ component:
port: 5173
protocol: TCP
targetPort: 5173

ingress:
enabled: false
# throttled locations
Expand Down