Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add additionalNginxSettings for frontend configuration #530

Merged
merged 6 commits into from
Nov 4, 2024

Conversation

liyaka
Copy link
Contributor

@liyaka liyaka commented Oct 31, 2024

Details

  • Added an option to add nginx configuration settings for Opik FE (Values.component.frontend.additionalNginxSettings)
  • update workflows to use the latest version of checkout action

Issues

Resolves #

Testing

Documentation

@liyaka liyaka requested review from a team as code owners October 31, 2024 16:51
@liyaka liyaka requested review from ferc and Nimrod007 October 31, 2024 17:08
@liyaka liyaka requested a review from a team as a code owner November 4, 2024 09:42
@liyaka liyaka force-pushed the liya/add-vars-for-nginx-config branch from ca5a091 to f015b30 Compare November 4, 2024 09:42
andrescrz
andrescrz previously approved these changes Nov 4, 2024
Copy link
Collaborator

@andrescrz andrescrz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left one comment, you can move forward if it doesn't apply.

.github/workflows/python_sdk_unit_tests.yml Outdated Show resolved Hide resolved
@liyaka liyaka merged commit 1c81f4f into main Nov 4, 2024
2 checks passed
@liyaka liyaka deleted the liya/add-vars-for-nginx-config branch November 4, 2024 09:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants