[OPIK-160] Fix trace and span error during insertion due to input/output size #362
+48
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thiagohora
changed the title
thiagohora
force-pushed
the
thiagohora/OPIK-160_error_when_inserting_span_and_trace
branch
from
643d98e to
f615637
Compare
Nimrod007
approved these changes
Oct 9, 2024
|
Merging, but FYI, @andrescrz. I believe we can discuss this with the consultancy. |
thiagohora
deleted the
thiagohora/OPIK-160_error_when_inserting_span_and_trace
branch
This makes sense. From the very beginning it was very suspicious that the failing payload was very big. During our discussions, it was on the table that size might have been the culprit, but we initially focused on the formatting issue first. I'm glad you managed to reproduce and fix this. Well done! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Details
Testing locally, we managed to reproduce the error, which was apparently due to some truncation of the statement. A temporary fix is to increase the query size limit. However, we will address this soon with the ClickHouse consultancy
Issues
#OPIK-160
Testing
Add tests to simulate error
Documentation