Fix tests

comet-ml · Oct 9, 2024 · f615637 · f615637
1 parent 6892993
commit f615637
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 6 deletions.
diff --git a/apps/opik-backend/src/test/java/com/comet/opik/api/resources/v1/priv/SpansResourceTest.java b/apps/opik-backend/src/test/java/com/comet/opik/api/resources/v1/priv/SpansResourceTest.java
@@ -2319,7 +2319,7 @@ void getByProjectName__whenFilterFeedbackScoresEqual__thenReturnSpansFiltered()
                                             .map(feedbackScore -> feedbackScore.toBuilder()
                                                     .value(podamFactory.manufacturePojo(BigDecimal.class))
                                                     .build())
-                                            .toList())
+                                            .collect(Collectors.toList()))
                             .build())
                     .collect(Collectors.toCollection(ArrayList::new));
 
@@ -2380,7 +2380,7 @@ void getByProjectName__whenFilterFeedbackScoresGreaterThan__thenReturnSpansFilte
                                             .map(feedbackScore -> feedbackScore.toBuilder()
                                                     .value(podamFactory.manufacturePojo(BigDecimal.class))
                                                     .build())
-                                            .toList(),
+                                            .collect(Collectors.toList()),
                                     2, 1234.5678))
                             .build())
                     .collect(Collectors.toCollection(ArrayList::new));
@@ -2435,7 +2435,7 @@ void getByProjectName__whenFilterFeedbackScoresGreaterThanEqual__thenReturnSpans
                                     .map(feedbackScore -> feedbackScore.toBuilder()
                                             .value(podamFactory.manufacturePojo(BigDecimal.class))
                                             .build())
-                                    .toList(), 2, 1234.5678))
+                                    .collect(Collectors.toList()), 2, 1234.5678))
                             .build())
                     .collect(Collectors.toCollection(ArrayList::new));
             spans.set(0, spans.getFirst().toBuilder()
@@ -2485,7 +2485,7 @@ void getByProjectName__whenFilterFeedbackScoresLessThan__thenReturnSpansFiltered
                                     .map(feedbackScore -> feedbackScore.toBuilder()
                                             .value(podamFactory.manufacturePojo(BigDecimal.class))
                                             .build())
-                                    .toList(), 2, 2345.6789))
+                                    .collect(Collectors.toList()), 2, 2345.6789))
                             .build())
                     .collect(Collectors.toCollection(ArrayList::new));
             spans.set(0, spans.getFirst().toBuilder()
@@ -2535,7 +2535,7 @@ void getByProjectName__whenFilterFeedbackScoresLessThanEqual__thenReturnSpansFil
                                     .map(feedbackScore -> feedbackScore.toBuilder()
                                             .value(podamFactory.manufacturePojo(BigDecimal.class))
                                             .build())
-                                    .toList(), 2, 2345.6789))
+                                    .collect(Collectors.toList()), 2, 2345.6789))
                             .build())
                     .collect(Collectors.toCollection(ArrayList::new));
             spans.set(0, spans.getFirst().toBuilder()

diff --git a/apps/opik-backend/src/test/java/com/comet/opik/api/resources/v1/priv/TracesResourceTest.java b/apps/opik-backend/src/test/java/com/comet/opik/api/resources/v1/priv/TracesResourceTest.java
@@ -3436,11 +3436,14 @@ void createAndGet__whenTraceInputIsBig__thenReturnSpan() {
                     .projectId(null)
                     .input(JsonUtils.readTree(jsonMap))
                     .output(JsonUtils.readTree(jsonMap))
+                    .feedbackScores(null)
+                    .usage(null)
                     .build();
 
             create(expectedTrace, API_KEY, TEST_WORKSPACE);
 
-            getAndAssert(expectedTrace, getProjectId(expectedTrace.projectName(), TEST_WORKSPACE, API_KEY), API_KEY, TEST_WORKSPACE);
+            UUID projectId = getProjectId(expectedTrace.projectName(), TEST_WORKSPACE, API_KEY);
+            getAndAssert(expectedTrace, projectId, API_KEY, TEST_WORKSPACE);
         }
 
     }