Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add docker compose and simple nginx config for it #245

Merged
merged 6 commits into from
Sep 16, 2024

Conversation

liyaka
Copy link
Contributor

@liyaka liyaka commented Sep 15, 2024

Details

Issues

Resolves #

Testing

Documentation

@liyaka liyaka requested a review from a team as a code owner September 15, 2024 14:45
@liyaka liyaka requested a review from Nimrod007 September 15, 2024 14:45
Nimrod007
Nimrod007 previously approved these changes Sep 15, 2024
Copy link
Collaborator

@jverre jverre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added a few suggestions, two main things to update before we merge:

  1. Add a volume for Mysql so the data is not lost between restarts
  2. Update backend service so that the migration runs

docker-compose.yaml Outdated Show resolved Hide resolved
docker-compose.yaml Outdated Show resolved Hide resolved
docker-compose.yaml Outdated Show resolved Hide resolved
docker-compose.yaml Outdated Show resolved Hide resolved
docker-compose.yaml Outdated Show resolved Hide resolved
docker-compose.yaml Outdated Show resolved Hide resolved
@liyaka
Copy link
Contributor Author

liyaka commented Sep 15, 2024

Moved compose to separate folder with README

@liyaka liyaka force-pushed the liya/add-docker-compose branch from cf31525 to 0358c13 Compare September 15, 2024 19:43
@liyaka liyaka requested review from Nimrod007 and a team September 15, 2024 19:43
Nimrod007
Nimrod007 previously approved these changes Sep 15, 2024
Copy link
Collaborator

@Nimrod007 Nimrod007 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

minor changes on version in readme

@liyaka liyaka force-pushed the liya/add-docker-compose branch from 0e19f09 to 899808e Compare September 15, 2024 21:12
jverre
jverre previously approved these changes Sep 16, 2024
@liyaka liyaka merged commit 7bff92c into main Sep 16, 2024
2 checks passed
@liyaka liyaka deleted the liya/add-docker-compose branch September 16, 2024 08:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants