Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

KUBESAW-129: Makefile target to check compatibility of local version with other repos #437

Merged
merged 9 commits into from
Aug 23, 2024

Conversation

fbm3307
Copy link
Contributor

@fbm3307 fbm3307 commented Jul 24, 2024

Description

This second part of dependency check

There is a makefile target that validates compatibility of the local version in other repositories that rely on them

Similar-Related PR in Toolchain-common - codeready-toolchain/toolchain-common#417

Checks

  1. Did you run make generate target? NA

  2. Did make generate change anything in other projects (host-operator, member-operator)? NA

  3. In case of new CRD, did you the following? NA

  4. In case other projects are changed, please provides PR links.
    NA

make/go.mk Outdated Show resolved Hide resolved
make/go.mk Outdated Show resolved Hide resolved
make/go.mk Outdated Show resolved Hide resolved
make/go.mk Outdated Show resolved Hide resolved
make/go.mk Outdated Show resolved Hide resolved
@fbm3307 fbm3307 requested a review from MatousJobanek August 7, 2024 12:19
Copy link

Copy link
Contributor

@mfrancisc mfrancisc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job 👏

Copy link
Contributor

@MatousJobanek MatousJobanek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job 👍 Thanks for addressing all the comments and moving it to a script. This is much easier to read and maintain 🥇

@MatousJobanek MatousJobanek merged commit de5ee82 into codeready-toolchain:master Aug 23, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants