Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

KS129 change the sequence of make file target #1065

Merged
merged 1 commit into from
Jul 26, 2024

Conversation

fbm3307
Copy link
Contributor

@fbm3307 fbm3307 commented Jul 26, 2024

This is related to the discussion
codeready-toolchain/api#437 (comment)

Copy link

Copy link
Contributor

@MatousJobanek MatousJobanek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Copy link

openshift-ci bot commented Jul 26, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: fbm3307, MatousJobanek

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link

codecov bot commented Jul 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.06%. Comparing base (af78831) to head (887ae52).

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1065      +/-   ##
==========================================
- Coverage   85.08%   85.06%   -0.02%     
==========================================
  Files          55       55              
  Lines        5034     5034              
==========================================
- Hits         4283     4282       -1     
- Misses        580      581       +1     
  Partials      171      171              

see 1 file with indirect coverage changes

@fbm3307 fbm3307 merged commit 2dae24c into codeready-toolchain:master Jul 26, 2024
10 of 12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants