-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
entity field support #416
Merged
Merged
entity field support #416
Changes from 3 commits
Commits
Show all changes
11 commits
Select commit
Hold shift + click to select a range
610789b
entity field support
joshreisner 4950a1b
fix test
joshreisner eb48a38
refactor
joshreisner 8f42d19
Merge branch 'main' into entity-fields
joshreisner 07e164e
rebuild app.js after merge
joshreisner e7cf7a9
Merge branch 'main' into entity-fields
joshreisner 0845743
resolve merge conflicts & rebuild app.js
joshreisner fd30026
Merge branch 'main' into entity-fields
joshreisner 05bd6e5
rebuild app.js
joshreisner b3bcf1d
improve tests
joshreisner 2a21ae0
more test coverage
joshreisner File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
Large diffs are not rendered by default.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -22,16 +22,11 @@ | |
<body> | ||
<div | ||
id="tsml-ui" | ||
data-src="https://docs.google.com/spreadsheets/d/12Ga8uwMG4WJ8pZ_SEU7vNETp_aQZ-2yNVsYDFqIwHyE/edit#gid=0" | ||
data-src="https://docs.google.com/spreadsheets/d/17hg4oj-V_tnRJn5zrRbAAtlEsDM9pN_KeQBUu7QLfy4/edit?gid=0#gid=0" | ||
data-mapbox="pk.eyJ1Ijoiam9zaHJlaXNuZXIiLCJhIjoiY2tvYXA0YnZxMGRldDJxbzdta25uNGphdiJ9.eay-UKgIT99ALmdw08xBPw" | ||
data-google="AIzaSyCS9M8Dqk5cMFqA7xvUrQEzT1u5IvcbT7c" | ||
data-timezone="America/Los_Angeles" | ||
></div> | ||
<script src="/app.js" async></script> | ||
<script> | ||
var tsml_react_config = { | ||
feedback_emails: ['[email protected]'], | ||
}; | ||
</script> | ||
</body> | ||
</html> |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,17 +1,22 @@ | ||
import { Meeting } from '../types'; | ||
|
||
import { formatArray } from './format-array'; | ||
import { formatString as i18n } from './format-string'; | ||
import { formatUrl } from './format-url'; | ||
import { getQueryString } from './query-string'; | ||
|
||
// send back a mailto link to a feedback email | ||
export function formatFeedbackEmail( | ||
feedback_emails: TSMLReactConfig['feedback_emails'], | ||
meeting: Meeting, | ||
settings: TSMLReactConfig, | ||
strings: Translation | ||
) { | ||
export function formatFeedbackEmail({ | ||
feedback_emails, | ||
edit_url, | ||
name, | ||
settings, | ||
strings, | ||
}: { | ||
feedback_emails: string[]; | ||
edit_url?: string; | ||
name?: string; | ||
settings: TSMLReactConfig; | ||
strings: Translation; | ||
}) { | ||
// remove extra query params from meeting URL | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. don't need to pass the whole meeting in |
||
const input = getQueryString(settings); | ||
const meetingUrl = formatUrl({ meeting: input.meeting }, settings); | ||
|
@@ -24,13 +29,13 @@ export function formatFeedbackEmail( | |
'-----', | ||
i18n(strings.email_public_url, { url: meetingUrl }), | ||
]; | ||
if (meeting.edit_url) { | ||
lines.push(i18n(strings.email_edit_url, { url: meeting.edit_url })); | ||
if (edit_url) { | ||
lines.push(i18n(strings.email_edit_url, { url: edit_url })); | ||
} | ||
|
||
// build mailto link | ||
return `mailto:${formatArray(feedback_emails).join()}?${new URLSearchParams({ | ||
subject: i18n(strings.email_subject, { name: meeting.name }), | ||
subject: i18n(strings.email_subject, { name }), | ||
body: lines.join('\n'), | ||
}) | ||
.toString() | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
to keep this page a little simpler we're forming the
feedback_url
inload-meeting-data