Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

entity field support #416

Merged
merged 11 commits into from
Oct 6, 2024
Merged

entity field support #416

merged 11 commits into from
Oct 6, 2024

Conversation

joshreisner
Copy link
Contributor

Screenshot 2024-09-24 at 8 41 28 PM

@joshreisner joshreisner requested a review from gkovats September 25, 2024 03:50
@joshreisner joshreisner self-assigned this Sep 25, 2024
Copy link

netlify bot commented Sep 25, 2024

Deploy Preview for tsml-ui ready!

Name Link
🔨 Latest commit 2a21ae0
🔍 Latest deploy log https://app.netlify.com/sites/tsml-ui/deploys/66feb7be2a97c00008bffed0
😎 Deploy Preview https://deploy-preview-416--tsml-ui.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@joshreisner
Copy link
Contributor Author

joshreisner commented Sep 25, 2024

strings
);
}

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

to keep this page a little simpler we're forming the feedback_url in load-meeting-data

name?: string;
settings: TSMLReactConfig;
strings: Translation;
}) {
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

don't need to pass the whole meeting in

@joshreisner
Copy link
Contributor Author

going to move this forward so i can start on other things - this won't have an impact on any sites currently other than moving the "update meeting info" button inside the panel at the bottom

@joshreisner joshreisner merged commit f13e406 into main Oct 6, 2024
5 of 6 checks passed
@joshreisner joshreisner deleted the entity-fields branch October 6, 2024 13:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant