Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

zk/dleq: Adding DLEQ proofs for Qn, the subgroup of squares in (Z/nZ)* #451

Merged
merged 1 commit into from
Jan 23, 2024

Conversation

armfazh
Copy link
Contributor

@armfazh armfazh commented Jul 18, 2023

This is required to enable verification of shares in threshold RSA.

@armfazh armfazh added the new feature New functionality or module label Jul 18, 2023
@armfazh armfazh requested a review from bwesterb July 18, 2023 15:25
@armfazh armfazh self-assigned this Jul 18, 2023
@armfazh armfazh force-pushed the dleq_in_qn branch 2 times, most recently from d6a6422 to 24eb204 Compare July 19, 2023 00:43
zk/qndleq/qndleq.go Outdated Show resolved Hide resolved
}

func mustWrite(w io.Writer, b []byte) {
n, err := w.Write(b)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Write on Shake128 never errors.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

true, but linter can compliant

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

_, _ = w.Write(b) will work.

Copy link
Member

@bwesterb bwesterb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See comments.

@armfazh armfazh force-pushed the dleq_in_qn branch 2 times, most recently from ddea170 to 5f5fa64 Compare January 23, 2024 02:17
@armfazh armfazh requested a review from bwesterb January 23, 2024 02:17
Copy link
Member

@bwesterb bwesterb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One little nit, but otherwise it's ok.

@armfazh armfazh merged commit 5ea9155 into cloudflare:main Jan 23, 2024
10 checks passed
@armfazh armfazh deleted the dleq_in_qn branch January 23, 2024 20:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new feature New functionality or module
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants