Skip to content

Commit

Permalink
- fixed combobox dynamic submenus not working
Browse files Browse the repository at this point in the history
- fixed synthgroup spread parameter knob not being initialised correctly
  • Loading branch information
christoph-hart committed Oct 7, 2024
1 parent 0017547 commit 4ef97e7
Show file tree
Hide file tree
Showing 5 changed files with 6 additions and 4 deletions.
2 changes: 1 addition & 1 deletion currentGitHash.txt
Original file line number Diff line number Diff line change
@@ -1 +1 @@
cc52289596f83b98fa709b1e257170bf080c7fdd
00175473082c61c640732e37f6ee1fe453406d90
2 changes: 1 addition & 1 deletion hi_backend/backend/currentGit.h
Original file line number Diff line number Diff line change
@@ -1 +1 @@
#define PREVIOUS_HISE_COMMIT "cc52289596f83b98fa709b1e257170bf080c7fdd"
#define PREVIOUS_HISE_COMMIT "00175473082c61c640732e37f6ee1fe453406d90"
1 change: 1 addition & 0 deletions hi_core/hi_modules/synthesisers/editors/GroupBody.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -173,6 +173,7 @@ GroupBody::GroupBody (ProcessorEditor *p)
spreadSlider->setup(getProcessor(), ModulatorSynthGroup::SpecialParameters::UnisonoSpread, "Spread");
spreadSlider->setMode(HiSlider::Mode::NormalizedPercentage);
spreadSlider->setRange(0.0, 2.0, 0.01);
spreadSlider->setValue(getProcessor()->getAttribute(ModulatorSynthGroup::SpecialParameters::UnisonoSpread), dontSendNotification);

spreadSlider->setIsUsingModulatedRing(true);
detuneSlider->setIsUsingModulatedRing(true);
Expand Down
2 changes: 2 additions & 0 deletions hi_core/hi_modules/synthesisers/editors/GroupBody.h
Original file line number Diff line number Diff line change
Expand Up @@ -68,6 +68,8 @@ class GroupBody : public ProcessorEditorBody,
modSelector->clear(dontSendNotification);
carrierSelector->clear(dontSendNotification);



auto offset = (int)ModulatorSynthGroup::InternalChains::numInternalChains;

carrierSelector->addItem("Enable All Synths", -1);
Expand Down
3 changes: 1 addition & 2 deletions hi_scripting/scripting/api/ScriptComponentWrappers.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -1169,9 +1169,8 @@ void ScriptCreatedComponentWrappers::ComboBoxWrapper::updateFont(ScriptComponent
void ScriptCreatedComponentWrappers::ComboBoxWrapper::updateItems(HiComboBox * cb)
{
cb->clear(dontSendNotification);
cb->rebuildPopupMenu();

cb->addItemList(dynamic_cast<ScriptingApi::Content::ScriptComboBox*>(getScriptComponent())->getItemList(), 1);
cb->rebuildPopupMenu();

auto currentValue = (int)getScriptComponent()->getValue();
cb->setSelectedId(currentValue, dontSendNotification);
Expand Down

0 comments on commit 4ef97e7

Please sign in to comment.