- fix compiing scripts only saving currently edited file

- fix compiling all scripts not saving any edited files

currentGitHash.txt

@@ -1 +1 @@
-ee19fcc0670facfdd2d34384291d3e7b1516cf8b
+cc52289596f83b98fa709b1e257170bf080c7fdd

hi_backend/backend/currentGit.h

@@ -1 +1 @@
-#define PREVIOUS_HISE_COMMIT "ee19fcc0670facfdd2d34384291d3e7b1516cf8b" 
+#define PREVIOUS_HISE_COMMIT "cc52289596f83b98fa709b1e257170bf080c7fdd" 

hi_core/hi_core/GlobalScriptCompileBroadcaster.cpp

@@ -214,6 +214,22 @@ void GlobalScriptCompileBroadcaster::setWebViewRoot(File newRoot)
 	webViewRoot = newRoot;
 }
 
+void GlobalScriptCompileBroadcaster::saveAllExternalFiles()
+{
+	for(int i = 0; i < getNumExternalScriptFiles(); i++)
+	{
+		auto ef = getExternalScriptFile(i);
+
+		if(ef->getResourceType() == ExternalScriptFile::ResourceType::EmbeddedInSnippet)
+		{
+			debugToConsole(dynamic_cast<MainController*>(this)->getMainSynthChain(), "Skip writing embedded file " + ef->getFile().getFileName() + " to disk...");
+			continue;
+		}
+
+		ef->saveFile();
+	}
+}
+
 
 void GlobalScriptCompileBroadcaster::sendScriptCompileMessage(JavascriptProcessor *processorThatWasCompiled)
 {
@@ -522,4 +538,20 @@ File ExternalScriptFile::getFile() const
 
 ExternalScriptFile::RuntimeError::Broadcaster& ExternalScriptFile::getRuntimeErrorBroadcaster()
 { return runtimeErrorBroadcaster; }
+
+bool ExternalScriptFile::extractEmbedded()
+{
+	if(resourceType == ResourceType::EmbeddedInSnippet)
+	{
+		if(!file.existsAsFile() || PresetHandler::showYesNoWindow("Overwrite local file", "The file " + getFile().getFileName() + " from the snippet already exists. Do you want to overwrite your local file?"))
+		{
+			file.getParentDirectory().createDirectory();
+			file.replaceWithText(content.getAllContent());
+			resourceType = ResourceType::FileBased;
+			return true;
+		}
+	}
+
+	return false;
+}
 } // namespace hise

hi_core/hi_core/GlobalScriptCompileBroadcaster.h

@@ -179,21 +179,7 @@ class ExternalScriptFile : public ReferenceCountedObject
 		return resourceType;
 	}
 
-	bool extractEmbedded()
-	{
-		if(resourceType == ResourceType::EmbeddedInSnippet)
-		{
-			if(!file.existsAsFile() || PresetHandler::showYesNoWindow("Overwrite local file", "The file " + getFile().getFileName() + " from the snippet already exists. Do you want to overwrite your local file?"))
-			{
-				file.getParentDirectory().createDirectory();
-				file.replaceWithText(content.getAllContent());
-				resourceType = ResourceType::FileBased;
-				return true;
-			}
-		}
-
-		return false;
-	}
+	bool extractEmbedded();
 
 private:
 
@@ -294,6 +280,8 @@ class GlobalScriptCompileBroadcaster
 
 	void setWebViewRoot(File newRoot);
 
+	void saveAllExternalFiles();
+
 private:
 
 	File webViewRoot;

hi_core/hi_core/MainController.cpp

@@ -510,6 +510,8 @@ void MainController::compileAllScripts()
 	JavascriptProcessor *sp;
 
 	Processor* first = nullptr;
+
+	saveAllExternalFiles();
 
 	while((sp = it.getNextProcessor()) != nullptr)
 	{

hi_scripting/scripting/components/PopupEditors.cpp

@@ -607,17 +607,8 @@ File PopupIncludeEditor::getFile() const
 
 void PopupIncludeEditor::compileInternal()
 {
-	if (externalFile != nullptr)
-	{
-		if(externalFile->getResourceType() == ExternalScriptFile::ResourceType::EmbeddedInSnippet)
-		{
-			debugToConsole(dynamic_cast<Processor*>(getScriptProcessor()), "Skip writing embedded file " + externalFile->getFile().getFileName() + " to disk...");
-		}
-		else
-		{
-            externalFile->saveFile();
-		}
-	}
+	auto mc = dynamic_cast<Processor*>(getScriptProcessor())->getMainController();
+	mc->saveAllExternalFiles();
 
 	if(t == FileTypes::CSS)
 	{