Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Number instead of Int for plural arguments #215

Merged
merged 1 commit into from
Aug 19, 2023

Conversation

theisenp
Copy link
Collaborator

@theisenp theisenp commented Aug 18, 2023

Currently we require Int for plural arguments, but the underlying ICU library supports formatting with Long, Double, etc.

There are plenty of use cases where this is valid, so it should be supported by Paraphrase. For example:

{length, plural,
  one {The race is 1 mile long}
  other {The race is # miles long}
}

// The race is 26.2 miles long

Partially addresses #207

@theisenp theisenp marked this pull request as ready for review August 18, 2023 22:03
@theisenp theisenp force-pushed the ptheisen/2023-08-18/plural-number branch from 22f4729 to fb94614 Compare August 18, 2023 22:35
@theisenp theisenp merged commit e0a94e3 into main Aug 19, 2023
3 checks passed
@theisenp theisenp deleted the ptheisen/2023-08-18/plural-number branch August 19, 2023 00:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants