Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Number instead of Int for choice arguments #220

Merged
merged 1 commit into from
Aug 24, 2023

Conversation

theisenp
Copy link
Collaborator

Similar to #215. The underlying ICU library supports decimal numbers for choice arguments, so we should too.

{0, choice, 0#Zero | 0.5#Half | 1<{0,number}}

The official documentation discourages the use of choice arguments in favor of plural, select, etc so in practice people shouldn't hit this too often. But it's an easy fix so why not.

Partially addresses #207.

@theisenp theisenp merged commit b666ba9 into main Aug 24, 2023
3 checks passed
@theisenp theisenp deleted the ptheisen/2023-08-24/choice-number branch August 24, 2023 18:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants