Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

reboot functionality, win device enumeration fix, list hid devices, rk84-iso support #47

Merged
merged 14 commits into from
Mar 9, 2024

Conversation

carlossless
Copy link
Owner

@carlossless carlossless commented Mar 9, 2024

Initiated from #45 and #46

This PR adds:

  • Sorting to device enumeration, so that data and request devices on Windows are selected deterministically.
  • Reboot functionality for devices that use bootloaders that are currently known to support it - cfc8661d. Also exposed as an arg, so that it can be enabled/disabled whenever that's not the default option for the device/bootloader.
  • A section in the readme tracking bootloader / host platform support and bootloader / function support.
  • The Royal Kludge RK84 part.
  • A new debugging function meant to list out all connected HID devices.

Thanks to @Luro02 who tracked down the device enumeration issue and proposed a fix for it (along with the reboot feature, list feature, and rk84 device report)!

@carlossless carlossless changed the title reboot functionality, win device enumeration fix, rk84-iso support reboot functionality, win device enumeration fix, list hid devices, rk84-iso support Mar 9, 2024
@carlossless
Copy link
Owner Author

@Luro02 could you please test data and request device selection changes in this PR with your setup?

@carlossless carlossless added enhancement New feature or request device-report labels Mar 9, 2024
@carlossless carlossless marked this pull request as ready for review March 9, 2024 18:45
@Luro02
Copy link
Contributor

Luro02 commented Mar 9, 2024

The fork works on my keyboard without any problems, including the rebooting.

@carlossless carlossless merged commit 68a6f6a into master Mar 9, 2024
9 checks passed
@carlossless carlossless deleted the feature/reboot branch March 9, 2024 20:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
device-report enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants