-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
reboot functionality, win device enumeration fix, list hid devices, rk84-iso support #47
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…oaders, added a compatibality section to readme
carlossless
force-pushed
the
feature/reboot
branch
from
March 9, 2024 16:54
a739988
to
aa54af8
Compare
carlossless
changed the title
reboot functionality, win device enumeration fix, rk84-iso support
reboot functionality, win device enumeration fix, list hid devices, rk84-iso support
Mar 9, 2024
@Luro02 could you please test data and request device selection changes in this PR with your setup? |
The fork works on my keyboard without any problems, including the rebooting. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Initiated from #45 and #46
This PR adds:
data
andrequest
devices on Windows are selected deterministically.cfc8661d
. Also exposed as an arg, so that it can be enabled/disabled whenever that's not the default option for the device/bootloader.Thanks to @Luro02 who tracked down the device enumeration issue and proposed a fix for it (along with the reboot feature, list feature, and rk84 device report)!