-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for RK84 ISO keyboard #46
Conversation
@Luro02 I'll test the reboot functionality and take a look at this in about a week or two. 👍 |
As mentioned in #45 (comment) the real issue is that it selects the wrong device for request/data. For fixing this, we need to differentiate between the two devices, the problem is that they only differ in the path:
I pushed a temporary solution that swaps them if the selected request device has |
Hey @Luro02, Thanks for all your efforts here! I used your changes to create #47. I did a couple of adjustments on top of your PR:
Also, I was able to successfully reboot my air60 when using your bootloader! However, I noticed that this I'll close this PR, so let's continue the discussion on #47 |
…k84-iso support (#47) Initiated from #45 and #46 This PR adds: * Sorting to device enumeration, so that `data` and `request` devices on Windows are selected deterministically. * Reboot functionality for devices that use bootloaders that are currently known to support it - `cfc8661d`. Also exposed as an arg, so that it can be enabled/disabled whenever that's not the default option for the device/bootloader. * A section in the readme tracking bootloader / host platform support and bootloader / function support. * The Royal Kludge RK84 part. * A new debugging function meant to list out all connected HID devices. Thanks to @Luro02 who tracked down the device enumeration issue and proposed a fix for it (along with the reboot feature, list feature, and rk84 device report)! --------- Co-authored-by: Luro02 <[email protected]>
This PR should close #45. It is a mystery to me why it did not initially find my keyboard and now it works.