Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[feat] Publishes image with "latest" tag in addition to rock version #7

Merged
merged 2 commits into from
Oct 5, 2023
Merged

[feat] Publishes image with "latest" tag in addition to rock version #7

merged 2 commits into from
Oct 5, 2023

Conversation

gruyaume
Copy link
Collaborator

@gruyaume gruyaume commented Oct 5, 2023

Description

Publishes image with "latest" tag in addition to rock version.

Checklist

  • I have performed a self-review of my own code.
  • I have made corresponding changes to the documentation.
  • I have added tests that validate the behaviour of the software.
  • I validated that new and existing tests pass locally with my changes.
  • Any dependent changes have been merged and published in downstream modules.

@gruyaume gruyaume requested a review from a team as a code owner October 5, 2023 11:54
@gruyaume gruyaume mentioned this pull request Oct 5, 2023
Merged
5 tasks
ghislainbourgeois
ghislainbourgeois approved these changes Oct 5, 2023
View reviewed changes
Copy link
Contributor

@ghislainbourgeois ghislainbourgeois left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small comment about an alternative, but this is fine as is

.github/workflows/publish-rock.yaml Outdated Show resolved Hide resolved
@gruyaume gruyaume merged commit 725255e into main Oct 5, 2023
5 checks passed
@gruyaume gruyaume deleted the dev-latest branch October 5, 2023 14:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ghislainbourgeois ghislainbourgeois ghislainbourgeois approved these changes

@DanielArndt DanielArndt DanielArndt approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@gruyaume @DanielArndt @ghislainbourgeois