Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[chore] Removes version from contributing.md #6

Merged
merged 3 commits into from
Oct 5, 2023
Merged

Conversation

gruyaume
Copy link
Collaborator

@gruyaume gruyaume commented Oct 4, 2023

Description

The goal here is to make our life easier when needing to update the Vault version. Now we only have to update 1 file when that's the case (rockcraft.yaml)

Checklist

  • I have performed a self-review of my own code.
  • I have made corresponding changes to the documentation.
  • I have added tests that validate the behaviour of the software.
  • I validated that new and existing tests pass locally with my changes.
  • Any dependent changes have been merged and published in downstream modules.

@gruyaume gruyaume requested a review from a team as a code owner October 4, 2023 17:14
CONTRIBUTING.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
@gruyaume gruyaume changed the title [chore] Makes version only relevant in rockcraft.yaml [chore] Removes version from contributing.md Oct 5, 2023
@gruyaume gruyaume merged commit 337b15f into main Oct 5, 2023
5 checks passed
@gruyaume gruyaume deleted the dev-version branch October 5, 2023 13:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants