Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't try to refocus on an app of the same client. #3714

Merged
merged 1 commit into from
Jan 9, 2025
Merged

Don't try to refocus on an app of the same client. #3714

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 1 addition & 4 deletions src/miral/basic_window_manager.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -288,9 +288,6 @@ void miral::BasicWindowManager::refocus(
if (hint && select_active_window(hint))
return;

if (can_activate_window_for_session_in_workspace(application, workspaces_containing_window))
return;
Comment on lines -291 to -292
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@AlanGriffiths this was here since you introduced MirAL… 8 years ago…

Can you comment on whether you're OK with this change?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems like only yesterday!

With what I now know about window management, it just looks wrong.


// Try to activate to recently active window of any application in a shared workspace
{
miral::Window new_focus;
Expand Down Expand Up @@ -2993,4 +2990,4 @@ void miral::BasicWindowManager::move_cursor_to(mir::geometry::PointF point)
sink->handle_input(std::move(event));
});
});
}
}
Loading