Don't try to refocus on an app of the same client. #3714
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Saviq
approved these changes
Jan 9, 2025
Comment on lines
-291
to
-292
| if (can_activate_window_for_session_in_workspace(application, workspaces_containing_window)) | ||
| return; |
There was a problem hiding this comment.
@AlanGriffiths this was here since you introduced MirAL… 8 years ago…
Can you comment on whether you're OK with this change?
There was a problem hiding this comment.
It seems like only yesterday!
With what I now know about window management, it just looks wrong.
AlanGriffiths
approved these changes
Jan 9, 2025
Comment on lines
-291
to
-292
| if (can_activate_window_for_session_in_workspace(application, workspaces_containing_window)) | ||
| return; |
There was a problem hiding this comment.
It seems like only yesterday!
With what I now know about window management, it just looks wrong.
Saviq
deleted the
MIRENG-452/closing-a-window-brings-one-of-the-remaining-windows-of-the-same-client-to-the-front
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3309
Note that this bug only occurs with apps that can have multiple windows running under the same process (example: gnome-terminal, pluma)