Display loading component in exchange operations #21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
akolotov
reviewed
Apr 9, 2020
dmihal
reviewed
Apr 9, 2020
patitonar
commented
Apr 13, 2020
akolotov
reviewed
Apr 13, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relates to #6
This PR updates the exchange plugin to display a Loading component (similar to transfer operations) when exchanging assets.
I added a custom loading message property to the Pairs. It is useful especially for pairs that use a bridge, so the user can be properly informed that it requires some time to finish the operation.
Also, I refactored the
XDaiBridgecomponent, to extract the common functionality of bridges to a separate Bridge class, so new bridges pairs can be added easily.Finally, the bridge exchange operations were updated to resolve when the asset from the other network is transferred to the user instead of when the transaction of the user is mined. This allows displaying the Loading component all the time until the assets are relayed by the bridge.