Detect xdai transfers from the bridge #4
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Apr 14, 2020
dmihal
approved these changes
Apr 14, 2020
| this.core.addHistoryEvent({ | ||
| id: `${event.transactionHash}-${event.logIndex}`, | ||
| asset: this.id, | ||
| type: 'send', |
There was a problem hiding this comment.
If you want, you could define your own "event type".
Of course, the UI modules (modern-ui) would need to be updated to display them.
akolotov
reviewed
Apr 14, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As a continuation to improve the UX of the exchange operations in burner-wallet/burner-wallet-2#21, this PR extends the
xdaiasset definition to detect when xdai native tokens are minted to the account as a result of exchanging DAI to xDai using the bridge.With this improvement, the UI will be able to display the incoming tokens to the account in the recent activity list.
The
getTxmethod was updated to return the data stored in theHistoryEventsif it is a transaction that includes a registered event from the bridge. In that case, it will display that information in theTransaction Receiptdetails instead of retrieving and showing the actual information of the transaction that will no make much sense because it is a call from a validator to the bridge address with zero value.Also, I updated some of the assets types to match the implementation.