Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: subscribing on wallets #44

Closed
wants to merge 4 commits into from
Closed

fix: subscribing on wallets #44

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
5deb9c1
Fixed subscribing on wallets
Aug 1, 2023
c7fb201
Removed lastUpdatedAssets
Aug 2, 2023
f193cc3
Fixed check for empty assets
Aug 2, 2023
6ec66e7
Merge branch 'broxus:main' into main
MaxSKuzin Aug 11, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 4 additions & 5 deletions lib/src/repositories/ton_wallet_repository/ton_wallet_repository_impl.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -171,7 +171,7 @@ mixin TonWalletRepositoryImpl implements TonWalletRepository {
Future<void> updateSubscriptions(List<TonWalletAsset> assets) async {
final last = lastUpdatedAssets;
final toSubscribe = <TonWalletAsset>[];
final toUnsubscribe = <TonWalletAsset>[];
final toUnsubscribe = <TonWallet>[];

// Stop last created operation if possible
final oldOperation = _lastOperation;
Expand All @@ -183,11 +183,11 @@ mixin TonWalletRepositoryImpl implements TonWalletRepository {
if (last != null) {
toUnsubscribe.addAll(
// pick all elements from old list, which is not contains in a new list
last.where((l) => !assets.any((a) => a.address == l.address)),
wallets.where((l) => !assets.any((a) => a.address == l.address)),
);
toSubscribe.addAll(
// pick all elements from new list, which is not contains in old list
assets.where((a) => !last.any((l) => l.address == a.address)),
assets.where((a) => !wallets.any((l) => l.address == a.address)),
);
} else {
toSubscribe.addAll(assets);
Expand All @@ -197,8 +197,6 @@ mixin TonWalletRepositoryImpl implements TonWalletRepository {
unsubscribe(asset.address);
}

lastUpdatedAssets = assets;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you don't updatelastUpdatedAssets, then you mustn't use last != null expression. Imho, it's better to remove lastUpdatedAssets, trying to use wallets for all checks. Look through the same behaviour in TokenWalletrepositoryImpl


late CancelableOperation<void> operation;

operation = CancelableOperation.fromFuture(() async {
Expand All @@ -217,6 +215,7 @@ mixin TonWalletRepositoryImpl implements TonWalletRepository {
// stop subscribing.
if (operation.isCanceled) return;
}
lastUpdatedAssets = assets;
}());
_lastOperation = operation;

Expand Down
Loading