fix: subscribing on wallets #44
Conversation
| @@ -197,8 +197,6 @@ mixin TonWalletRepositoryImpl implements TonWalletRepository { | |||
| unsubscribe(asset.address); | |||
| } | |||
|
|
|||
| lastUpdatedAssets = assets; | |||
There was a problem hiding this comment.
If you don't updatelastUpdatedAssets, then you mustn't use last != null expression. Imho, it's better to remove lastUpdatedAssets, trying to use wallets for all checks. Look through the same behaviour in TokenWalletrepositoryImpl
| @@ -225,15 +211,21 @@ mixin TonWalletRepositoryImpl implements TonWalletRepository { | |||
|
|
|||
| @override | |||
| Future<void> updateTransportSubscriptions() async { | |||
| closeAllSubscriptions(); | |||
| final assets = wallets | |||
There was a problem hiding this comment.
I think, this place is a bottle neck, because if you change transport until all subscriptions were completed, you will lose some part of wallets, so imho for this place you must use some cache list as it was lastUpdatedAddress and you won't lose necessary wallets. But lastUpdatedAddress must be used only here, so when you will revert this, leave a comment with description.
There was a problem hiding this comment.
Also waiting for TokenWalletRepositoryImpl with the same logic
|
Closed, because this logic implemented in #53 |
No description provided.