-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DC-958: Add notification for snapshot ready #301
Conversation
"snapshotExportLink" -> snapshotExportLink, | ||
"snapshotName" -> snapshotName, | ||
"snapshotSummary" -> snapshotSummary | ||
), Map.empty, Map.empty); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks for walking through this with me. the map here represents substitutions to be made in the body of the email. the empty maps here represent substitutions for a user's email and name. We get the first name for free from the user id, so we don't need that substitution and we don't use the email in the body of the email, so we don't need that substitution.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #301 +/- ##
===========================================
- Coverage 59.69% 55.92% -3.78%
===========================================
Files 14 17 +3
Lines 593 633 +40
Branches 53 69 +16
===========================================
Hits 354 354
- Misses 239 279 +40 ☔ View full report in Codecov by Sentry. |
Jira: https://broadworkbench.atlassian.net/browse/DC-1186
What:
Add a new notification message for the TDR snapshot ready event.
Why:
In Terra, Thurloe is used to send messages.
How:
The dependency on workbenchLibs was tested locally by using
sbt publishLocal
and using a pinned snapshot version; once the workbench-libs and terra-helmfile PRs are merged, I can merge this change up and test the notification support in dev.See also
https://github.com/broadinstitute/terra-helmfile/pull/5783
broadinstitute/workbench-libs#1697