Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DC-958: Add notification for snapshot ready #301

Merged
merged 4 commits into from
Aug 16, 2024

Conversation

pshapiro4broad
Copy link
Member

@pshapiro4broad pshapiro4broad commented Aug 2, 2024

Jira: https://broadworkbench.atlassian.net/browse/DC-1186

What:

Add a new notification message for the TDR snapshot ready event.

Why:

In Terra, Thurloe is used to send messages.

How:

The dependency on workbenchLibs was tested locally by using sbt publishLocal and using a pinned snapshot version; once the workbench-libs and terra-helmfile PRs are merged, I can merge this change up and test the notification support in dev.

See also

https://github.com/broadinstitute/terra-helmfile/pull/5783
broadinstitute/workbench-libs#1697


  • Submitter: Make sure Swagger is updated if API changes
  • Submitter: If updating admin endpoints, also update firecloud-admin-cli
  • Submitter: Update FISMA documentation if changes to:
    • Authentication
    • Authorization
    • Encryption
    • Audit trails
  • Submitter: If you're adding new libraries, sign us up to security updates for them

@pshapiro4broad pshapiro4broad changed the title DC-1168: Add notification for snapshot ready DC-1186: Add notification for snapshot ready Aug 2, 2024
@pshapiro4broad pshapiro4broad changed the title DC-1186: Add notification for snapshot ready DC-958: Add notification for snapshot ready Aug 8, 2024
@pshapiro4broad pshapiro4broad marked this pull request as ready for review August 13, 2024 20:18
"snapshotExportLink" -> snapshotExportLink,
"snapshotName" -> snapshotName,
"snapshotSummary" -> snapshotSummary
), Map.empty, Map.empty);

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for walking through this with me. the map here represents substitutions to be made in the body of the email. the empty maps here represent substitutions for a user's email and name. We get the first name for free from the user id, so we don't need that substitution and we don't use the email in the body of the email, so we don't need that substitution.

Copy link

codecov bot commented Aug 16, 2024

Codecov Report

Attention: Patch coverage is 0% with 10 lines in your changes missing coverage. Please review.

Project coverage is 55.92%. Comparing base (f2aab0a) to head (cd3c7b4).
Report is 2 commits behind head on develop.

Files Patch % Lines
...ala/thurloe/notification/NotificationMonitor.scala 0.00% 10 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #301      +/-   ##
===========================================
- Coverage    59.69%   55.92%   -3.78%     
===========================================
  Files           14       17       +3     
  Lines          593      633      +40     
  Branches        53       69      +16     
===========================================
  Hits           354      354              
- Misses         239      279      +40     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pshapiro4broad pshapiro4broad merged commit 31e040e into develop Aug 16, 2024
7 of 9 checks passed
@pshapiro4broad pshapiro4broad deleted the dc-1168-snapshot-notification-email branch August 16, 2024 13:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants