Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TSPS-140 Add Teaspoons notification types #360

Merged
merged 3 commits into from
Dec 10, 2024

Conversation

mmorgantaylor
Copy link
Member

@mmorgantaylor mmorgantaylor commented Dec 9, 2024

Jira: https://broadworkbench.atlassian.net/browse/TSPS-140

What:

Add two new notification messages for Teaspoons succeeded and failed jobs.

Why:

In Terra, Thurloe is used to send messages.

How:

Once this PR is merged, I can test the notification support in dev.

See also:
https://github.com/broadinstitute/terra-helmfile/pull/5984
broadinstitute/workbench-libs#1714

following pattern from similar work for TDR: #301

Note that the following workbench-libs PR also had to be merged to roll back some changes that were causing tests to fail; the workbench-libs version used here comes from this PR: broadinstitute/workbench-libs#1715


  • Submitter: Make sure Swagger is updated if API changes
  • Submitter: If updating admin endpoints, also update firecloud-admin-cli
  • Submitter: Update FISMA documentation if changes to:
    • Authentication
    • Authorization
    • Encryption
    • Audit trails
  • Submitter: If you're adding new libraries, sign us up to security updates for them

@mmorgantaylor mmorgantaylor requested a review from a team as a code owner December 9, 2024 19:45
@mmorgantaylor mmorgantaylor requested review from davidangb and marctalbott and removed request for a team December 9, 2024 19:45
Copy link

codecov bot commented Dec 10, 2024

Codecov Report

Attention: Patch coverage is 0% with 29 lines in your changes missing coverage. Please review.

Project coverage is 57.12%. Comparing base (164d540) to head (bc0dd89).
Report is 1 commits behind head on develop.

Files with missing lines Patch % Lines
...ala/thurloe/notification/NotificationMonitor.scala 0.00% 29 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #360      +/-   ##
===========================================
- Coverage    59.71%   57.12%   -2.60%     
===========================================
  Files           18       18              
  Lines          638      667      +29     
  Branches        66       65       -1     
===========================================
  Hits           381      381              
- Misses         257      286      +29     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mmorgantaylor mmorgantaylor merged commit d0a056c into develop Dec 10, 2024
7 of 9 checks passed
@mmorgantaylor mmorgantaylor deleted the TSPS-140_add_teaspoons_notifications branch December 10, 2024 20:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants