Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ID-1095 null default route #1355

Merged
merged 2 commits into from
Feb 16, 2024
Merged

ID-1095 null default route #1355

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c14985a
null default route
dvoet Feb 16, 2024
e1cf8ba
Merge branch 'develop' into default_null_route
dvoet Feb 16, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions src/main/scala/org/broadinstitute/dsde/workbench/sam/api/SamRequestContextDirectives.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -180,9 +180,11 @@ object AkkaHttpServerAttributesGetter extends HttpServerAttributesGetter[HttpReq

override def getUrlQuery(request: HttpRequest): String = request.uri.query().toString()

/** Defaults to the path of the request. Overridden by the `addTelemetry` directive.
/** Defaults to the null. Overridden by the `addTelemetry` directive. This defaults to null because the route is used in metrics and we need to prevent a
* cardinality explosion. If we defaulted to the uri path, then any request with path parameters would default to a unique route until overridden by
* `addTelemetry` which might not happen in the case of errors or bugs.
*/
override def getHttpRoute(request: HttpRequest): String = getUrlPath(request)
override def getHttpRoute(request: HttpRequest): String = null

override def getHttpRequestMethod(request: HttpRequest): String = request.method.value

Expand Down
Loading