Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ID-1095 null default route #1355

Merged
merged 2 commits into from
Feb 16, 2024
Merged

ID-1095 null default route #1355

merged 2 commits into from
Feb 16, 2024

Conversation

dvoet
Copy link
Collaborator

@dvoet dvoet commented Feb 16, 2024

Ticket: https://broadworkbench.atlassian.net/browse/ID-1095

In my latest iteration of sam metrics on dev I found that when there is an error before we are able to figure out the route (e.g. unregistered user or user has not accepted TOS), the http path is used in the http route metrics tag leading to cardinality issues in dev. This might not be an acute problem in prod but it is a vulnerability. This PR makes the default null which also protects against cardinality problem if route does not update telemetry correctly.


PR checklist

  • I've followed the instructions if I've made any changes to the API, especially if they're breaking changes
  • I've filled out the Security Risk Assessment (requires Broad Internal network access) and attached the result to the JIRA ticket

Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@dvoet dvoet merged commit 4690e4b into develop Feb 16, 2024
20 of 21 checks passed
@dvoet dvoet deleted the default_null_route branch February 16, 2024 19:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants