Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticket: https://broadworkbench.atlassian.net/browse/ID-1095
In my latest iteration of sam metrics on dev I found that when there is an error before we are able to figure out the route (e.g. unregistered user or user has not accepted TOS), the http path is used in the http route metrics tag leading to cardinality issues in dev. This might not be an acute problem in prod but it is a vulnerability. This PR makes the default
null
which also protects against cardinality problem if route does not update telemetry correctly.PR checklist