Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Import header from brainglobe-utils #188

Merged
merged 2 commits into from
Apr 22, 2024
Merged

Import header from brainglobe-utils #188

merged 2 commits into from
Apr 22, 2024

Conversation

K-Meech
Copy link
Contributor

@K-Meech K-Meech commented Apr 15, 2024

Description

What is this PR

  • Bug fix
  • Addition of a new feature
  • Other

Why is this PR needed?
Currently, the brainreg widget has no header (i.e. no brainglobe logo / documentation links...).

What does this PR do?
This PR adds a header from brainglobe-utils. As this increases the length of an already long widget, a vertical scrollbar is also added to make navigation easier. This uses the same QScrollArea solution as the cellfinder detect and train widgets. These scrollbars aren't ideal as they require using internal (marked with _) values from the magicgui widget. A better solution would be to change all widgets to use qtpy directly, but this isn't a very quick fix.
Screenshot 2024-04-15 113356

References

For brainglobe/cellfinder#327

How has this PR been tested?

All tests pass locally.

Is this a breaking change?

No

Does this PR require an update to the documentation?

No

Checklist:

  • The code has been tested locally
  • Tests have been added to cover all new functionality (unit & integration)
  • The documentation has been updated to reflect any changes
  • The code has been formatted with pre-commit

@K-Meech K-Meech requested a review from a team April 15, 2024 10:49
@adamltyson adamltyson mentioned this pull request Apr 22, 2024
@adamltyson
Copy link
Member

Thanks @K-Meech. I've raised an issue about converting to qtpy (#190).

@adamltyson adamltyson merged commit 7010a0b into main Apr 22, 2024
12 checks passed
@adamltyson adamltyson deleted the header branch April 22, 2024 16:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants