Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move #![warn(clippy::allow_attributes, clippy::allow_attributes_without_reason)] to the workspace Cargo.toml #17374

Merged
merged 19 commits into from
Jan 15, 2025
Merged

Move #![warn(clippy::allow_attributes, clippy::allow_attributes_without_reason)] to the workspace Cargo.toml #17374

merged 19 commits into from
Jan 15, 2025
+73 −221

Conversation

LikeLakers2
Copy link
Contributor

@LikeLakers2 LikeLakers2 commented Jan 14, 2025 •
edited
Loading

Objective

Fixes #17111

Solution

Move #![warn(clippy::allow_attributes, clippy::allow_attributes_without_reason)] to the workspace Cargo.toml

Testing

Lots of CI testing, and local testing too.

@BenjaminBrienen BenjaminBrienen added D-Trivial Nice and easy! A great choice to get started with Bevy C-Code-Quality A section of code that is hard to understand or change A-Cross-Cutting Impacts the entire engine S-Waiting-on-Author The author needs to make changes or address concerns before this can be merged labels Jan 14, 2025
BenjaminBrienen
BenjaminBrienen suggested changes Jan 14, 2025
View reviewed changes
benches/benches/bevy_ecs/components/add_remove_very_big_table.rs Outdated Show resolved Hide resolved
crates/bevy_ecs/examples/resources.rs Outdated Show resolved Hide resolved
crates/bevy_ecs/examples/change_detection.rs Outdated Show resolved Hide resolved
@alice-i-cecile alice-i-cecile added this to the 0.16 milestone Jan 14, 2025
@LikeLakers2
Copy link
Contributor Author

LikeLakers2 commented Jan 14, 2025 •
edited
Loading

This PR will be removed from draft mode after CI completes successfully.

@LikeLakers2 LikeLakers2 mentioned this pull request Jan 14, 2025
Closed
2 tasks
@BenjaminBrienen BenjaminBrienen removed D-Trivial Nice and easy! A great choice to get started with Bevy S-Waiting-on-Author The author needs to make changes or address concerns before this can be merged labels Jan 14, 2025
@BenjaminBrienen BenjaminBrienen added D-Straightforward Simple bug fixes and API improvements, docs, test and examples S-Needs-Review Needs reviewer attention (from anyone!) to move forward labels Jan 14, 2025
@LikeLakers2 LikeLakers2 marked this pull request as ready for review January 14, 2025 23:21
@alice-i-cecile alice-i-cecile added this pull request to the merge queue Jan 15, 2025
@alice-i-cecile alice-i-cecile added S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it and removed S-Needs-Review Needs reviewer attention (from anyone!) to move forward labels Jan 15, 2025
Merged via the queue into bevyengine:main with commit 26bb0b4 Jan 15, 2025
35 checks passed
@LikeLakers2 LikeLakers2 deleted the lint/warn_on_allow_and_without_reason/bevy branch January 15, 2025 01:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BenjaminBrienen BenjaminBrienen BenjaminBrienen approved these changes

@alice-i-cecile alice-i-cecile alice-i-cecile approved these changes

Assignees
No one assigned
Labels
A-Cross-Cutting Impacts the entire engine C-Code-Quality A section of code that is hard to understand or change D-Straightforward Simple bug fixes and API improvements, docs, test and examples S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it
Projects
None yet
Milestone
0.16
Development

Successfully merging this pull request may close these issues.

Warn the clippy::allow_attributes and clippy::allow_attributes_without_reason lints
3 participants
@LikeLakers2 @alice-i-cecile @BenjaminBrienen