Add argument to ci for test threads and build jobs

[BenjaminBrienen]

Objective

Fixes #16051

Solution

Rework flags into arguments and add an arg for the number of test threads and an arg for the number of build jobs.

cargo run -p ci -- --test-threads 1 --build-jobs 1

Testing

Tested CI locally. Build pipeline should also be a good way to catch mistakes in the command line usage.

[hukasu]

Also should fix #12207

[BenjaminBrienen]

Also should fix #12207

More of a workaround than a fix, I think.

[BD103]

Looks good!

[hukasu]

I'm not understanding how to use the --jobs arg.

--help gives this Usage: ci [--keep-going] [--test-threads <test-threads>] [--jobs <jobs>] [<command>] [<args>], but using cargo run -p ci -- --jobs 4 doc gives error: Unrecognized option: 'jobs4', and using cargo run -p ci -- --jobs=4 doc gives Unrecognized argument: --jobs=4.

[hukasu]

--test-threads worked great, no OOM during bevy_gizmos tests

[hukasu]

@BenjaminBrienen does --jobs work for you?

[BenjaminBrienen]

I'll test it when I have time later

[hukasu]

pulled d7d808d and now i can pass --jobs but the build is still using more parallelism

cargo run -p ci -- --jobs 4 fails on cargo fmt because it does not take --jobs

cargo run -p ci -- --jobs 4 doc fails with

error: Unrecognized option: 'jobs'
error: doctest failed, to rerun pass `-p benches --doc`
thread 'main' panicked at tools/ci/src/ci.rs:72:13:
One or more CI commands failed:
doc-test: Please fix failing doc tests in output above.

and i saw on the console that it is passing as a string(?)

cargo test --workspace --doc " --jobs 4" -- 

[hukasu]

cargo run -p ci -- --jobs 4 bench-check also fails with --jobs being included between quotes

cargo check --benches --target-dir ../target --manifest-path "./benches/Cargo.toml --jobs 4"

[BenjaminBrienen]

I'll look at this more later thanks

[hukasu]

cargo run -p ci -- --jobs 4 clippy is quoting

cargo clippy --workspace --all-targets "--all-features --jobs 4" -- -Dwarnings

[BenjaminBrienen]

Reading the documentation for cmd!, looks like I'll have to approach this differently. Maybe splatting will work.