Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: modernization #668

Merged
merged 3 commits into from
Sep 25, 2024
Merged

refactor: modernization #668

merged 3 commits into from
Sep 25, 2024

Conversation

doomspork
Copy link
Member

No description provided.

doomspork
doomspork commented Jun 27, 2024
View reviewed changes
.formatter.exs
@@ -1,7 +1,7 @@
# This file is synced with beam-community/common-config. Any changes will be overwritten.

[
import_deps: [],
import_deps: [:plug],
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need to see why common-config didn't detect plug.

@doomspork doomspork changed the title Refactor modernization refactor: modernization Jun 27, 2024
@doomspork doomspork mentioned this pull request Jul 15, 2024
Merged
@doomspork doomspork force-pushed the refactor-modernization branch from a2545b4 to 951fb3b Compare September 25, 2024 16:42
@doomspork doomspork closed this Sep 25, 2024
@doomspork doomspork reopened this Sep 25, 2024
@doomspork doomspork force-pushed the refactor-modernization branch 3 times, most recently from ff309b4 to 0329551 Compare September 25, 2024 17:06
@doomspork doomspork mentioned this pull request Sep 25, 2024
Closed
@doomspork doomspork marked this pull request as ready for review September 25, 2024 17:13
@doomspork doomspork requested a review from a team as a code owner September 25, 2024 17:13
Base automatically changed from gha/actions-sync to main September 25, 2024 17:15
@doomspork doomspork force-pushed the refactor-modernization branch from 0329551 to 6986747 Compare September 25, 2024 17:17
btkostner
btkostner approved these changes Sep 25, 2024
View reviewed changes
Copy link
Member

@btkostner btkostner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mostly formatting changes. No code related changes. I looked over all of the tests to ensure it's only formatting and the tests still pass so we should be good to go.

@doomspork doomspork merged commit c13ff7b into main Sep 25, 2024
7 of 8 checks passed
@doomspork doomspork deleted the refactor-modernization branch September 25, 2024 17:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@btkostner btkostner btkostner approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@doomspork @btkostner