Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Elixir 1.17 warning about function call without parens #664

Merged

Conversation

michallepicki
Copy link
Contributor

@michallepicki michallepicki commented Jun 2, 2024

In e3d2079 I've fixed a warning about invoking a function without parentheses. It shows at run-time and looks like this:

warning: using map.field notation (without parentheses) to invoke function Bamboo.TestAdapter.supports_attachments?() is deprecated, you must add parentheses instead: remote.function()
  (bamboo 2.3.0) lib/bamboo/mailer.ex:307: Bamboo.Mailer.validate_attachment_support/2
  (bamboo 2.3.0) lib/bamboo/mailer.ex:289: Bamboo.Mailer.validate_and_normalize/2
  (bamboo 2.3.0) lib/bamboo/mailer.ex:240: Bamboo.Mailer.deliver_later/3

BEGIN_COMMIT_OVERRIDE
fix: Fix Elixir 1.17 warning about function call without parens
END_COMMIT_OVERRIDE

@yordis
Copy link
Member

yordis commented Jun 21, 2024

Hey @doomspork, I do not have the proper permission to help folks with this repo. Could you help me with it?

@doomspork
Copy link
Member

doomspork commented Jun 23, 2024

@yordis should be fixed! Separately, but related to related to CI (approved it to run btw), I want to work with you and @btkostner to standardize it across the org, including releases (see: https://github.com/beam-community/common-config). Hopefully reduce some of the overhead

@yordis
Copy link
Member

yordis commented Jun 23, 2024

I want to work with you and @btkostner to standardize it across the org

That is my intent, for sure. The owner role helps to unblock me cleaning things up to get to the final state 😄
I am trying to adopt the same workflow in Tesla.

@doomspork doomspork merged commit 1c1d002 into beam-community:main Jun 25, 2024
5 of 7 checks passed
@michallepicki michallepicki deleted the 24-06-02-fix-1-17-warnings branch June 25, 2024 21:37
@artkay
Copy link

artkay commented Jul 13, 2024

Hey folks @doomspork & @yordis - I am curious when a new Bamboo release is planned? The current version has been released in January 2023 and it produces warnings in Elixir 1.17.

@doomspork
Copy link
Member

@artkay I'm working on updating the library #668 and getting our new CI/CD process setup. There's a few dialyzer errors left to resolve and then we should be GTG!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants