Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

warning: using map.field notation (without parentheses) - under Elixir 1.17 #669

Closed
rob-vetspire opened this issue Sep 5, 2024 · 2 comments

Comments

@rob-vetspire
Copy link

When running tests under Elixir 1.17 with use Bamboo.Test we get the following warning printed in test log:

warning: using map.field notation (without parentheses) to invoke function 
Bamboo.TestAdapter.supports_attachments?() is deprecated, 
you must add parentheses instead: remote.function()
  (bamboo 2.3.0) lib/bamboo/mailer.ex:307: Bamboo.Mailer.validate_attachment_support/2
  (bamboo 2.3.0) lib/bamboo/mailer.ex:289: Bamboo.Mailer.validate_and_normalize/2
  (bamboo 2.3.0) lib/bamboo/mailer.ex:199: Bamboo.Mailer.deliver_now/4
  (bamboo 2.3.0) lib/bamboo/mailer.ex:231: Bamboo.Mailer.deliver_now!/4

Fix required in lib/bamboo/mailer.ex:

change supports_attachments?

to supports_attachments?()

@doomspork
Copy link
Member

@rob-vetspire PRs welcome!

@tonyrud
Copy link

tonyrud commented Oct 1, 2024

Looks like this was fixed here: #664

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants