Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: helm cleanup overkill #1757

Merged
merged 2 commits into from
Jan 16, 2024
Merged

fix: helm cleanup overkill #1757

merged 2 commits into from
Jan 16, 2024

Conversation

DerekRoberts
Copy link
Member

@DerekRoberts DerekRoberts commented Jan 16, 2024 •
edited by github-actions bot
Loading

Thanks for the PR!

Deployments, as required, will be available below:

Please create PRs in draft mode. Mark as ready to enable:

After merge, new images are deployed in:

@DerekRoberts DerekRoberts changed the title bug: helm cleanup overkill fix: helm cleanup overkill Jan 16, 2024
@DerekRoberts DerekRoberts marked this pull request as ready for review January 16, 2024 21:12
@DerekRoberts DerekRoberts self-assigned this Jan 16, 2024
@DerekRoberts DerekRoberts added the bug Something isn't working label Jan 16, 2024
@DerekRoberts DerekRoberts added this pull request to the merge queue Jan 16, 2024
mishraomp
mishraomp approved these changes Jan 16, 2024
View reviewed changes
Copy link
Collaborator

@mishraomp mishraomp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mishraomp
Copy link
Collaborator

thanks to @ikethecoder for reporting this issue, and thanks @DerekRoberts for fixing it :)

Merged via the queue into main with commit 91fc8ae Jan 16, 2024
31 of 33 checks passed
@DerekRoberts DerekRoberts deleted the bug/helmCleanup branch January 16, 2024 21:17
@DerekRoberts DerekRoberts linked an issue Jan 17, 2024 that may be closed by this pull request
Schedule Helm clean up is deleting resources outside of scope. #1755
Closed
@DerekRoberts DerekRoberts mentioned this pull request Jan 17, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mishraomp mishraomp mishraomp approved these changes

Assignees

@DerekRoberts DerekRoberts

Labels
bug Something isn't working
Projects
DevOps (NR)
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Schedule Helm clean up is deleting resources outside of scope.
2 participants
@DerekRoberts @mishraomp