Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Schedule Helm clean up is deleting resources outside of scope. #1755

Closed
mishraomp opened this issue Jan 15, 2024 · 3 comments · Fixed by #1757
Closed

Schedule Helm clean up is deleting resources outside of scope. #1755

mishraomp opened this issue Jan 15, 2024 · 3 comments · Fixed by #1757
Assignees
Labels
bug Something isn't working

Comments

@mishraomp
Copy link
Collaborator

Currently, the scheduled job that cleans up helm resources is removing helm installs outside the scope.

provide scope with release name to narrow down the uninstalls.

@mishraomp mishraomp added the bug Something isn't working label Jan 15, 2024
@DerekRoberts DerekRoberts moved this from New to Active in DevOps (NR) Jan 15, 2024
@DerekRoberts
Copy link
Member

@mishraomp Outside of scope? It's should be cleaning up anything a week old. Please explain?

@mishraomp
Copy link
Collaborator Author

mishraomp commented Jan 16, 2024

namespace can be used for other deployments outside of the repository, and the schedule jobs should not delete that.
for example:
Quickstart-openshift-* releases should be deleted but not if someone has Airflow or Airbyte deployed outside of this workflow.
@DerekRoberts

@DerekRoberts DerekRoberts linked a pull request Jan 17, 2024 that will close this issue
@DerekRoberts
Copy link
Member

Resolved by #1757.

@github-project-automation github-project-automation bot moved this from Active to Done in DevOps (NR) Jan 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

2 participants