Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: typing all any types #328

Merged
merged 4 commits into from
Jun 20, 2024
Merged

fix: typing all any types #328

merged 4 commits into from
Jun 20, 2024

Conversation

RMCampos
Copy link

@RMCampos RMCampos commented Jun 14, 2024 •
edited by github-actions bot
Loading

Description

Removes all any types.

Fixes SILVA-432

Type of change

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

Tested locally.

Checklist

  • I have read the CONTRIBUTING doc
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have already been accepted and merged

Further comments

Thanks for the PR!

Any successful deployments (not always required) will be available below.

Backend: https://nr-silva-328-backend.apps.silver.devops.gov.bc.ca/actuator/health
Frontend: https://nr-silva-28-frontend.apps.silver.devops.gov.bc.ca

Once merged, code will be promoted and handed off to following workflow run.
Main Merge Workflow

@RMCampos RMCampos self-assigned this Jun 14, 2024
@RMCampos RMCampos mentioned this pull request Jun 19, 2024
Merged
9 tasks
@RMCampos RMCampos marked this pull request as ready for review June 20, 2024 15:32
DerekRoberts
DerekRoberts approved these changes Jun 20, 2024
View reviewed changes
Copy link
Member

@DerekRoberts DerekRoberts left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Much better! :)

@RMCampos RMCampos merged commit 272143f into main Jun 20, 2024
16 checks passed
@RMCampos RMCampos deleted the feat/silva-432-fix-all-any-types branch June 20, 2024 18:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DerekRoberts DerekRoberts DerekRoberts approved these changes

@jazzgrewal jazzgrewal Awaiting requested review from jazzgrewal jazzgrewal is a code owner

Assignees

@RMCampos RMCampos

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@RMCampos @DerekRoberts