Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: hide checkbox when no spatial view #327

Merged
merged 5 commits into from
Jun 19, 2024

Conversation

RMCampos
Copy link

@RMCampos RMCampos commented Jun 14, 2024

Description

Simple change to address the Opening table behaviour accordingly to the Map View.

Fixes SILVA-424

Type of change

  • New feature (non-breaking change which adds functionality)

How Has This Been Tested?

Tested locally. Unit tests will be added shortly.

Checklist

  • I have read the CONTRIBUTING doc
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have already been accepted and merged

Further comments


Thanks for the PR!

Any successful deployments (not always required) will be available below.

Backend: https://nr-silva-327-backend.apps.silver.devops.gov.bc.ca/actuator/health
Frontend: https://nr-silva-27-frontend.apps.silver.devops.gov.bc.ca

Once merged, code will be promoted and handed off to following workflow run.
Main Merge Workflow

@RMCampos RMCampos self-assigned this Jun 14, 2024
@RMCampos RMCampos marked this pull request as ready for review June 18, 2024 22:42
Copy link
Member

@DerekRoberts DerekRoberts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are the lint warnings a big deal? If not, I'll approve as-is.

@RMCampos RMCampos requested a review from DerekRoberts June 19, 2024 14:14
@RMCampos
Copy link
Author

Are the lint warnings a big deal? If not, I'll approve as-is.

hey! Thanks for pointing that out. I fixed most of them. There are still issues with "any" type, that's being addressed here #328.

@RMCampos RMCampos merged commit 6eae484 into main Jun 19, 2024
16 checks passed
@RMCampos RMCampos deleted the feat/silva-424-hide-row-selection-whithout-spatial branch June 19, 2024 19:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants