fix: #692 Admin FOM should not be editable when commenting open.

[ianliuwk1019]

ref: #692
Business requirement changes due to issue the licenses edit FOM during commenting open (description field) and it has legal consequence. New rule: All FOM fields should not be editable except attachments fields during commenting open.

• Adjust fom-add-edit component so that fields are only new/editable during FOM initial state. On Commenting open and any other state they will be disabled. Some field are only editable during "create" (initial state).

---

Thanks for the PR!

Any successful deployments (not always required) will be available below.

• api
• admin
• public

Once merged, code will be promoted and handed off to following workflow run.

• Main Merge Workflow

---

Thanks for the PR!

Any successful deployments (not always required) will be available below.

• api
• admin
• public

Once merged, code will be promoted and handed off to following workflow run.

• Main Merge Workflow

[basilv]

So my main concern is that we're changing a number of fields to be only editable in initial state when they were editable in multiple states before. So what if these fields still need to be editable when commenting is closed? I'm not saying they need to be, but it isn't clear what change we are actually making, versus just making fields non-editable during commenting-open.

[craigyu]

I don't have things setup locally to test these but the code looks good!

[craigyu]

So my main concern is that we're changing a number of fields to be only editable in initial state when they were editable in multiple states before. So what if these fields still need to be editable when commenting is closed? I'm not saying they need to be, but it isn't clear what change we are actually making, versus just making fields non-editable during commenting-open.

I had a state here to control the inputs depends on whether the form is in "comment open" state
337ee0e

[ianliuwk1019]

So my main concern is that we're changing a number of fields to be only editable in initial state when they were editable in multiple states before. So what if these fields still need to be editable when commenting is closed? I'm not saying they need to be, but it isn't clear what change we are actually making, versus just making fields non-editable during commenting-open.

Thanks Basil! I adjusted the change, some fields are editable during commenting closed according to latest discussion from Julius.

[basilv]

Have some questions...

[DerekRoberts]

One more approval!