Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable FOM form modifications/updates when commenting period is open #692

Closed
3 tasks
OlgaLiber2 opened this issue Sep 11, 2024 · 4 comments · Fixed by #693
Closed
3 tasks

Disable FOM form modifications/updates when commenting period is open #692

OlgaLiber2 opened this issue Sep 11, 2024 · 4 comments · Fixed by #693

Comments

@OlgaLiber2
Copy link
Collaborator

Describe the task
Email from Julius:
Image

Image
Image

Acceptance Criteria

  • first
  • second
  • third

Additional context

  • Add any other context about the task here.
  • Or here
@OlgaLiber2 OlgaLiber2 changed the title Make FOM description field not editable when commenting period is open Disable FOM form modifications/updates when when commenting period is open Sep 11, 2024
@ianliuwk1019
Copy link
Collaborator

@basilv
I have created a urgent PR #693 just for frontend.
We will need to revisit backend to change/add/remove validation during "update".
@craigyu

@ianliuwk1019
Copy link
Collaborator

Clarification from Julius:
Image

Commenting Open Status:

1. Do not make any changes to the Commenting Open Date and Commenting Closed dates. Submitters should still be abled to lengthen/extend the commenting period, and reviewers should still be able to shorten or lengthen the commenting period
 
2. The following fields should be locked:  Start of Operation, End of Operation, FSP ID, District, FOM Name, Description

3. The document upload fields (Public Notice, Attachments) should remain open so people can upload/delete documents during the commenting open status (no change to current logic)

Commenting Closed Status:

1. The commenting open date and commenting closed date should be locked, District should be locked.
2. The following fields should stay open: Start of operations, end of operations, FSP ID (I changed my mind from what we discussed, people should be able to change it), FOM Name, Timber Sales Manager (if applicable), Description field (should be open again), upload fields for public notice and attachments should remain open (no change to current status)

@ianliuwk1019 ianliuwk1019 changed the title Disable FOM form modifications/updates when when commenting period is open Disable FOM form modifications/updates when commenting period is open Sep 12, 2024
@ianliuwk1019 ianliuwk1019 self-assigned this Sep 12, 2024
@ianliuwk1019
Copy link
Collaborator

Deployed to TEST for Julius to test.

@ianliuwk1019
Copy link
Collaborator

Julius tested and verified on TEST is good.
This is deployed to production today.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants